Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up KubeadmControlPlane Ready #2480

Closed
chuckha opened this issue Feb 28, 2020 · 3 comments · Fixed by #2488
Closed

Wire up KubeadmControlPlane Ready #2480

chuckha opened this issue Feb 28, 2020 · 3 comments · Fixed by #2488
Assignees
@chuckha
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.3.0

Comments

@chuckha
Copy link
Contributor

chuckha commented Feb 28, 2020 •
edited
Loading

It looks like KubeadmControlPlane's Ready field has not been wired up. Thanks to @Anuj2512 for pointing this out.

According to the godoc above the field, the KCP is ready as soon as the first control plane is ready to receive requests. This means that as soon as one control plane node has passed a health check we can set this field to true.

/kind bug
/milestone v0.3.0
/priority important-soon
/cc @detiber @randomvariable
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 28, 2020
@randomvariable
Copy link
Member

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 28, 2020
@randomvariable
Copy link
Member

ok, this was ambitious on a friday evening. might look at on monday if no one gets there first.
/unassign
/remove-lifecycle active

@k8s-ci-robot k8s-ci-robot removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 28, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Feb 28, 2020

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 28, 2020
@chuckha chuckha mentioned this issue Feb 28, 2020
Merged
@vincepri vincepri added area/control-plane Issues or PRs related to control-plane lifecycle management area/clusterctl Issues or PRs related to clusterctl and removed area/clusterctl Issues or PRs related to clusterctl labels Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

🏃 Wire up kubeadm control plane Ready status chuckha/cluster-api
4 participants
@chuckha @randomvariable @vincepri @k8s-ci-robot