Skip to content

Conversation

@sonasingh46
Copy link
Contributor

Signed-off-by: Ashutosh Kumar [email protected]

/kind feature

What this PR does / why we need it:

Adds control plane toleration for manager deployment.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2640

Add tolerations for control plane taints in manager deployment config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2022
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@jackfrancis
Copy link
Contributor

I thought there was a reason for these tolerations not being present. Maybe @CecileRobertMichon can comment when she returns.

Sorry @sonasingh46 if this is a pressing concern.

@mboersma
Copy link
Contributor

I don't think there's urgency to merging this. But the notes from our Sept. 1 meeting claim:

[Cecile] +1 on adding this toleration to capz components

Having said that, it's safer to take it slow, and I agree it's a bit odd we never added the previous toleration. So let's see if @CecileRobertMichon remembers anything else about this when she's back.

@jackfrancis
Copy link
Contributor

thanks @mboersma!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 57e2b22 into kubernetes-sigs:main Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Sep 14, 2022
@jackfrancis
Copy link
Contributor

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #2655

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor

No objections from me, thanks for getting this done!

@jackfrancis
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #2678

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add node-role.kubernetes.io/control-plane toleration to CAPZ manager deployment

6 participants