-
Notifications
You must be signed in to change notification settings - Fork 461
add toleration for control plane taints #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ashutosh Kumar <[email protected]>
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
I thought there was a reason for these tolerations not being present. Maybe @CecileRobertMichon can comment when she returns. Sorry @sonasingh46 if this is a pressing concern. |
|
I don't think there's urgency to merging this. But the notes from our Sept. 1 meeting claim:
Having said that, it's safer to take it slow, and I agree it's a bit odd we never added the previous toleration. So let's see if @CecileRobertMichon remembers anything else about this when she's back. |
|
thanks @mboersma! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.5 |
|
@jackfrancis: new pull request created: #2655 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
No objections from me, thanks for getting this done! |
|
/cherry-pick release-1.4 |
|
@jackfrancis: new pull request created: #2678 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ashutosh Kumar [email protected]
/kind feature
What this PR does / why we need it:
Adds control plane toleration for manager deployment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2640