Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart template does not install AWS cloud-controller-manager #4677

Closed
nrb opened this issue Dec 5, 2023 · 1 comment · Fixed by #4678
Closed

Quickstart template does not install AWS cloud-controller-manager #4677

nrb opened this issue Dec 5, 2023 · 1 comment · Fixed by #4678
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nrb
Copy link
Contributor

nrb commented Dec 5, 2023

/kind bug

What steps did you take and what happened:

Following the CAPI quickstart with Kubernetes v1.28, no AWS cloud-controller-manager is installed and the in-tree cloud controller manager is not used, apparently - trying to follow the quickstart results in only 4 nodes (one control plane, three workers) being created, but never being Ready.

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/templates/cluster-template.yaml sets the cloud provider to external, but does not contain a Deployment or DaemonSet that installs the AWS cloud-controller-manager.

What did you expect to happen:

Following the quickstart results in a usable cluster.

Anything else you would like to add:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/templates/cluster-template-external-cloud-provider.yaml contains the external cloud provider information, but is not the current default template. As the cloud controller managers are being removed from the Kubernetes code base into their own repositories, we should default to using the external code.

Environment:

  • Cluster-api-provider-aws version:
clusterawsadm version: &version.Info{Major:"2", Minor:"2", GitVersion:"v2.2.4", GitCommit:"56c9a39dd834640ee4a027e679ad2a5757098dfd", GitTreeState:"clean", BuildDate:"2023-10-05T09:43:40Z", GoVersion:"go1.21.0", AwsSdkVersion:"v1.44.213", Compiler:"gc", Platform:"darwin/arm64"}
  • Kubernetes version: (use kubectl version):
❯ k version
Client Version: v1.28.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3
  • OS (e.g. from /etc/os-release): macOS 13.6.2
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2023
@nrb
Copy link
Contributor Author

nrb commented Dec 6, 2023

/triage accepted
/assign @nrb

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants