feat: support sharing the primary slb with multiple vmSets#578
Conversation
There was a problem hiding this comment.
Want to prevent the 412 error here, even though the error won't break the logic because the retry wouldn't face the 412 error again.
There was a problem hiding this comment.
move to defer and only set it to true when the following operations have succeeded.
There was a problem hiding this comment.
and need pre-define the err above to catch the error inside defer function
There was a problem hiding this comment.
rename to shouldRemoveVMSetFromSLB()
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables multiple vmSets sharing the primary SLB. To do this, we need to:
nodePoolsWithoutDedicatedSLB(comma separated).Note that when switching from dedicated slb to shared slb, the service frontend IP configs would be moved to the primary slb as well, even if there is a mode annotation that selects the original non-primary vmSet. This could cause service downtime for some
localservices.Which issue(s) this PR fixes:
Fixes #549
Special notes for your reviewer:
Release note: