Allow to pass watcher strategy #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Member
Author
|
/retest |
Member
Author
seans3
approved these changes
Mar 20, 2023
Contributor
seans3
left a comment
seans3
left a comment
There was a problem hiding this comment.
Thanks for the addition.
/approve
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ash2k, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
I probably would have suggested dropping the Watcher- prefix and just making it the scope for the whole Applier/Destroyer. Then make a new higher level scope enum and translate it into the watch enum as needed. Then we could add some up front validation to validate scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently strategy is not specified and is always
RESTScopeAutomatic. I have a case where I need to set it toRESTScopeNamespace, but there is no way to set it. This PR exposes an option to make it possible.See #572 (comment) and the following conversation for the background.