-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --default-subnets option #4083
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 1mwataru The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @1mwataru! |
Hi @1mwataru. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
close #4046
Description
--default-subnets
option--default-subnets
will be selectedBackground
When subnets are not explicitly specified through annotations, subnets are selected in lexicographical order within each availability zone, and the load balancer is created with those subnets. (doc)
Due to this specification, if there are specific subnets where ELBs should be launched by default, annotations need to be added to all load balancers, which is cumbersome.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯
Manual tests
Prerequisites
AZ a
AZ b
AZ c
Default selection (lexicographical order)
subnet-1a-public, subnet-1b-public, subnet-1c-public
subnet-1a-private, subnet-1b-private, subnet-1c-private
Pattern 1
subnet-2a-public,subnet-2b-public,subnet-2a-private
in --default-subnets optionsubnet-2a-public,subnet-2b-public,subnet-1c-public
subnet-2a-private, subnet-1b-private, subnet-1c-private
Pattern 2
subnet-2a-public,subnet-1a-public
in --default-subnets optionsubnet-2a-public,subnet-1b-public,subnet-1c-public
subnet-1a-private, subnet-1b-private, subnet-1c-private