Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --default-subnets option #4083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1mwataru
Copy link

Issue

close #4046

Description

  • Added --default-subnets option
    • When subnets are not explicitly specified through annotations or other methods, the subnets specified in --default-subnets will be selected

Background

  • When subnets are not explicitly specified through annotations, subnets are selected in lexicographical order within each availability zone, and the load balancer is created with those subnets. (doc)

  • Due to this specification, if there are specific subnets where ELBs should be launched by default, annotations need to be added to all load balancers, which is cumbersome.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Manual tests

  • Prerequisites

    • AZ a

      • subnet-1a-public
      • subnet-2a-public
      • subnet-1a-private
      • subnet-2a-private
    • AZ b

      • subnet-1b-public
      • subnet-2b-public
      • subnet-1b-private
      • subnet-2b-private
    • AZ c

      • subnet-1c-public
      • subnet-2c-public
      • subnet-1c-private
      • subnet-2c-private
    • Default selection (lexicographical order)

      • Internet facing ELB is created with subnet-1a-public, subnet-1b-public, subnet-1c-public
      • Internal ELB is created with subnet-1a-private, subnet-1b-private, subnet-1c-private
  • Pattern 1

    • Specified subnet-2a-public,subnet-2b-public,subnet-2a-private in --default-subnets option
    • result:
      • Internet facing ELB is created with subnet-2a-public,subnet-2b-public,subnet-1c-public
      • Internal ELB is created with subnet-2a-private, subnet-1b-private, subnet-1c-private
  • Pattern 2

    • Specified subnet-2a-public,subnet-1a-public in --default-subnets option
    • result:
      • Internet facing ELB is created with subnet-2a-public,subnet-1b-public,subnet-1c-public
      • Internal ELB is created with subnet-1a-private, subnet-1b-private, subnet-1c-private
      • (when two subnets from the same AZ are specified, the first one takes precedence)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
Copy link

linux-foundation-easycla bot commented Mar 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 1mwataru / name: Wataru (9beab56)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 1mwataru
Once this PR has been reviewed and has the lgtm label, please assign shraddhabang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @1mwataru!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @1mwataru. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2025
@1mwataru 1mwataru marked this pull request as ready for review March 10, 2025 13:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Declarative defaults for subnets selected when there are multiple qualified
2 participants