Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Revert csi to v0.3.0 #150

Closed

Conversation

peter-wangxu
Copy link

kubernetes 1.12.x only supports v0.3.0
current versions in Gopkg.toml causes version conflict when
importing this project

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peter-wangxu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: saad-ali

If they are not already assigned, you can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2019
@peter-wangxu peter-wangxu force-pushed the fix_csi_version branch 2 times, most recently from 11d1c77 to 22be259 Compare February 18, 2019 08:31
kubernetes 1.12.x only supports v0.3.0
current versions in Gopkg.toml causes version conflict when
importing this project
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 18, 2019
@pohly
Copy link
Contributor

pohly commented Feb 18, 2019

We can't go back to 0.3.0 in this repo. A lot of code in it is based on 1.0.0.

I assume you are trying to vendor csi-common? Please note that:

@peter-wangxu
Copy link
Author

maybe we should changing the kubernetes to 1.13? the master versions (kubernetes 1.12/spec 1.0) should break other dependent projects:)

@pohly
Copy link
Contributor

pohly commented Feb 18, 2019

@peter-wangxu this repo is deprecated (#149). Nothing should depend on the master branch of this repo.

@peter-wangxu
Copy link
Author

@peter-wangxu this repo is deprecated (#149). Nothing should depend on the master branch of this repo.

Thanks, then I shall close it now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants