Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PVCVolumeSnapshotRefList from VolumeGroupSnapshot API #1202

Closed
xing-yang opened this issue Nov 20, 2024 · 0 comments · Fixed by #1200
Closed

Remove PVCVolumeSnapshotRefList from VolumeGroupSnapshot API #1202

xing-yang opened this issue Nov 20, 2024 · 0 comments · Fixed by #1200
Assignees

Comments

@xing-yang
Copy link
Collaborator

What happened:
PVCVolumeSnapshotRefList was originally added to the Status of VolumeGroupSnapshot API so that a user knows which individual VolumeSnapshot is corresponding to which PVC when doing a restore: #969

For dynamic provisioning of VolumeGroupSnapshot, we changed volumeSnapshotContentName to persistentVolumeClaimName in the Source field of individual VolumeSnapshot objects, and changed snapshotHandle to volumeHandle in the Source field of individual VolumeSnapshotContent objects. So we no longer need PVCVolumeSnapshotRefList in the Status of VolumeGroupSnapshot for the purpose of finding the matching PVC to do restore from a VolumeSnapshot.

For static provisioning, the VolumeSnapshot Source only contains volumeSnapshotContentName and the VolumeSnapshotContent Source only contains snapshotHandle. This means the original individual volume snapshot API objects don't contain any information about the PVC name or volume handle. It is assumed that the admin should have this information. Therefore the VolumeGroupSnapshot API does not need to provide extra information about the source PVCs.

Therefore it is now safe to remove PVCVolumeSnapshotRefList from VolumeGroupSnapshot API.

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants