Update release tools #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new variables for 1.16 and remove 1.13
This is the latest release. Updating is useful to ensure that we have all of the latest fixes and enhancements.
Some operations are sensitive to the version of Go that is used. In the past, formatting of source differed depending on the version. Right now it is the content of the vendor directory which changes when switch back and forth between 1.12 and 1.13. We don't want to impose a certain workflow on developers, like forcing all invocations of Go to run inside a container. If developers want that, they can set up their development environment accordingly. But we should warn about this aspect to raise awareness. "make" invocations which involve Go now compare against the projects Go version (specified in travis.yml) once at the beginning. This is only a warning because we don't know which future version will be compatible with the project. Vendor directory handling gets updated, too: verification is now a separate script (became too complex for make) and there is a corresponding "update-vendor.sh". In contrast to verification, updating vendor is not integrated into make and thus itself invokes the go version check.
Go version 1.13, helper scripts
This avoids dependencies on the Go module cache or the upstream code hosting.
prow.sh: use vendor directory if available
Depending on the error, those logs are needed to debug failures.
prow.sh: also log output of system containers
Inside a real Prow job it is better to clean up at runtime instead of leaving that to the Prow job cleanup code because the later sometimes times out. Signed-off-by: Mucahit Kurt <[email protected]>
…eanup delete kind cluster after tests run
Signed-off-by: Grant Griffiths <[email protected]>
Add snapshotter CRDs after cluster setup
Adding build for ppc64le
kind v0.6.0 appends the kubeconfig with the default config at ~/.kube/config.
Use kind v0.6.0
…ure can be tested. Test cases that test accessing volumes from multiple nodes need to be skipped
Signed-off-by: Grant Griffiths <[email protected]>
Enable topology testing with hostpath driver
…ersion_gt Improve snapshot-controller running check and version_gt to support multiple formats
fix syntax for ppc64le build
Improve README by adding an explicit Kubernetes dependency section
This requires adding one more parallel e2e test run with a special focus flag because snapshot tests are still guarded with a "[Feature:VolumeSnapshotDataSource]" tag. The setting that skips all tests with "[Feature:.*]" has to be removed because it overrides the focus. We don't have serial snapshot tests yet. This needs to be modified again if we add any in the future.
Enable snapshot tests in 1.17 to be run in non-alpha jobs.
Signed-off-by: Grant Griffiths <[email protected]>
…netes_fix Fix version_gt to work with Kubernetes prefix
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-csi-external-resizer-1-16-on-kubernetes-1-16 |
|
CI failure is due to two reasons:
|
k8s-ci-robot
removed
the
lgtm
msau42
reviewed
Jan 2, 2020
release-tools/prow.sh
Outdated
| @@ -183,7 +187,7 @@ configvar CSI_PROW_WORK "$(mkdir -p "$GOPATH/pkg" && mktemp -d "$GOPATH/pkg/csip | |||
| # | |||
| # When no deploy script is found (nothing in `deploy` directory, | |||
| # CSI_PROW_HOSTPATH_REPO=none), nothing gets deployed. | |||
| configvar CSI_PROW_HOSTPATH_VERSION "v1.2.0-rc8" "hostpath driver" | |||
| configvar CSI_PROW_HOSTPATH_VERSION "v1.2.0" "hostpath driver" | |||
There was a problem hiding this comment.
I just tagged an rc for hostpath repo which has the beta snapshots changes. Can you try setting v1.3.0-rc2 here?
|
The tests ran but results got clobbered. Investigating... |
Update prow hostpath driver version to 1.3.0-rc2
Fix overriding of junit results
saad-ali
force-pushed
the
updateReleaseTools
branch
from
936ef9a
to
d8fef29
Compare
|
Rebased with kubernetes-csi/csi-release-tools#60 and kubernetes-csi/csi-release-tools#61 merged. All green now. PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Update release-tools to head of https://github.com/kubernetes-csi/csi-release-tools/ master branch
Changes go build version from 1.12.4 to 1.13.3
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: