Update K8s dependency go modules for K8s v1.26.0-rc.0

[sunnylovestiramisu]

Ran

release-tools/go-get-kubernetes.sh -p 1.26.0-rc.0

[k8s-ci-robot]

Welcome @sunnylovestiramisu!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sunnylovestiramisu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

/ok-to-test

[msau42]

Did the script generate the PR title? I would probably clarify that this is updating the Kubernetes dependencies

[sunnylovestiramisu]

Yes it does, we can specify whatever title we want.

[humblec]

@sunnylovestiramisu Thanks for the PR.. but few comments from my end. imo, we dont bring rc updates to the repo, atleast released minor versions. This script also require some cleaning after getting the kube versions..etc, for ex: the unwanted replace directives. Also considering we have automated this process of updating the dependencies via dependabot, this PR shouldnt be necessary.

[sunnylovestiramisu]

@sunnylovestiramisu Thanks for the PR.. but few comments from my end. imo, we dont bring rc updates to the repo, atleast released minor versions. This script also require some cleaning after getting the kube versions..etc, for ex: the unwanted replace directives. Also considering we have automated this process of updating the dependencies via dependabot, this PR shouldnt be necessary.

@humblec Thank you for the information! :) So the dependabot has already covered both the script release-tools/update-vendor.sh and release-tools/go-get-kubernetes.sh? Then we should update the documentation: csi-release-tools/blob/master/SIDECAR_RELEASE_PROCESS.md ?

[msau42]

@humblec I'm not sure if dependabot can handle kubernetes version updating (at least I have not seen it https://github.com/kubernetes-csi/external-provisioner/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed).

[msau42]

In terms of whether we should wait for 1.26.0, I think it's fine to update to rc.0 now, and then update once more to 1.26.0 before we do the final release. That way we can start running tests with the new deps sooner. I don't expect signficant changes between rc.0 and .0

[humblec]

@humblec I'm not sure if dependabot can handle kubernetes version updating (at least I have not seen it https://github.com/kubernetes-csi/external-provisioner/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed).

Oh.. yes, it can - as long as its not excluded in package list.. we can also see such instance here . https://github.com/kubernetes-csi/volume-data-source-validator/pulls @msau42

[humblec]

In terms of whether we should wait for 1.26.0, I think it's fine to update to rc.0 now, and then update once more to 1.26.0 before we do the final release. That way we can start running tests with the new deps sooner. I don't expect signficant changes between rc.0 and .0

Ok.. if the plan is to get the tests run early, it should be fine . 👍

[humblec]

I think its better to remove this replace section.

[xing-yang]

+1

[msau42]

It looks like the script is relying on the replace statements to do special handling for the kubernetes libraries that don't follow the same version naming scheme. @pohly do you know if it is safe to skip this logic if the repo does not import k/k?

https://github.com/kubernetes-csi/csi-release-tools/blob/master/go-get-kubernetes.sh#L125

[pohly]

If the repo doesn't use k/k, then it should be safe to drop the replace statements.

[sunnylovestiramisu]

/retest

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xing-yang]

/release-note-none