verify shellcheck #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In repos that have a test/e2e, that test suite should be run separately because it depends on a running cluster.
This is an unmodified copy of kubernetes/hack/verify-shellcheck.sh revision d5a3db003916b1d33b503ccd2e4897e094d8af77.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Merged
msau42
reviewed
Apr 1, 2019
util.sh
Outdated
|
|
||
| # Run all known doc generators (today gendocs and genman for kubectl) | ||
| # $1 is the directory to put those generated documents | ||
| kube::util::gen-docs() { |
There was a problem hiding this comment.
Many of these functions do not seem relevant for us. Can we remove the unused ones?
There was a problem hiding this comment.
I kept some smaller functions which may become useful.
| @@ -0,0 +1,187 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Can you add a README describing what are we validating with this script?
These are the modifications that were necessary to call this outside of Kubernetes. The support for excluding files from checking gets removed to simplify the script. It shouldn't be needed, because linting can be enabled after fixing whatever scripts might fail the check.
By default this only tests the scripts inside the "release-tools" directory, which is useful when making experimental changes to them in a component that uses csi-release-tools. But a component can also enable checking for other directories.
k8s-ci-robot
added
size/L
|
@msau42 updated. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jsafrane
pushed a commit
to jsafrane/csi-release-tools
that referenced
this pull request
May 10, 2024
Add Connect function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used for the Prow test script and could also be applied to other scripts, like for example the deploy.sh script in csi-driver-host-path.