Failing closed after maximum retry is achieved to avoid inf recursion

[knabben]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind bug

What this PR does / why we need it:
Adding a maximum retry for the CSI to find the volume target from a mountpath.

Which issue(s) this PR fixes:

Fixes #193

Special notes for your reviewer:
Tracking the recursion call trace here:
#193 (comment)

Does this PR introduce a user-facing change?:

Maximum retry (3) when for the getTarget method iterate and find the correct volume of the mount path. 

[k8s-ci-robot]

Hi @knabben. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knabben]

/assign @mauriciopoppe

[knabben]

This (and other calls) needs a real coverage

[mauriciopoppe]

Agreed, it'd be hard to setup a scenario with symlinks so that (Get-Item -Path $Env:mountpath).Target works though.

[jsturtevant]

/ok-to-test

[k8s-ci-robot]

@jsturtevant: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mauriciopoppe]

/ok-to-test

[mauriciopoppe]

Agreed, it'd be hard to setup a scenario with symlinks so that (Get-Item -Path $Env:mountpath).Target works though.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knabben
Once this PR has been reviewed and has the lgtm label, please ask for approval from mauriciopoppe. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mauriciopoppe]

I believe CI is failing because the kubernetes startup script on GCE instances is not working for Windows, cc @AnishShah

[AnishShah]

I had filed kubernetes/kubernetes#124047 to track sig-windows-gce test job failures.

[mauriciopoppe]

/retest

[knabben]

@mauriciopoppe any news in the gcp windows testing?

[mauriciopoppe]

Thanks for following up, our CI infra is up and running but a presubmit within Github Actions failed with tests unrelated with this change:

=== RUN   TestSmbAPIGroup/v1alpha1SmbTests
    smb_v1alpha1_test.go:30: TestSmbAPIGroup setupUser failed: exit status 1, output: "ConvertTo-SecureString : The 'ConvertTo-SecureString' command was found in the module 'Microsoft.PowerShell.Security', \r\nbut the module could not be loaded. For more information, run 'Import-Module Microsoft.PowerShell.Security'.\r\nAt line:1 char:10\r\n+ $PWord = ConvertTo-SecureString $Env:password -AsPlainText -Force;New ...\r\n+          ~~~~~~~~~~~~~~~~~~~~~~\r\n    + CategoryInfo          : ObjectNotFound: (ConvertTo-SecureString:String) [], CommandNotFoundException\r\n    + FullyQualifiedErrorId : CouldNotAutoloadMatchingModule\r\n \r\nNew-LocalUser : Cannot validate argument on parameter 'Password'. The argument is null. Provide a valid value for the \r\nargument, and then try running the command again.\r\nAt line:1 char:132\r\n+ ... w-Localuser -name $Env:username -accountneverexpires***                                                                    ~~~~~~\r\n    + CategoryInfo          : InvalidData: (:) [New-LocalUser], ParameterBindingValidationException\r\n    + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.PowerShell.Commands.NewLocalUserCommand\r\n \r\n"

The failure above (only CI setup in Github actions) would need to be fixed in another PR and then we can retrigger presubmit tests in this PR to finally get it merged.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale