Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iscsiplugin image tag v0.1.0 was pushed again overwriting the existing image tag #97

Closed
mauriciopoppe opened this issue Feb 3, 2022 · 4 comments
Assignees

Comments

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Feb 3, 2022

What happened:
In kubernetes/k8s.io#3345 (comment) we found out that the v0.1.0 image was overwritten, once an image is released it should be considered immutable and we shouldn't overwrite the tag, if there are critical bug fixes I think we should bump the image.

I'm not sure about the fix, we could:

  • ask the owner of k8s.gcr.io to manually remove the existing v0.1.0 image (I'm not sure if this is allowed)
  • retag the v0.1.0 canary in sig-storage-staging to point to the existing tag sha256:31117074c183242b223340f2fc0f886243e97c6cb1a83d98cfb00a69d1746697 and rerun the image promoter again

/cc @msau42

@msau42
Copy link
Collaborator

msau42 commented Feb 3, 2022

/assign @humblec

@humblec
Copy link
Contributor

humblec commented Feb 4, 2022

@msau42 yeah, my bad, it shouldnt have been overwritten eventhough both hashes [1] are same code .
"sha256:31117074c183242b223340f2fc0f886243e97c6cb1a83d98cfb00a69d1746697"
"sha256:8ff2016fd563f0365ccf6ad4ab09f09a1941cbede5c62c5692e95589c0ed41de"

Can I remove the first or existing hash in a PR and quickly a followup PR with other hash? I believe it should be fine as max it could cause a small disruption if some one pull in between? also considering both are pointing to the same binary should it be fine?

Thanks @mauriciopoppe

@humblec
Copy link
Contributor

humblec commented Feb 4, 2022

kubernetes/k8s.io#3351 remove the first hash. If this is not allowed, the second method retagging the existing hash to v0.1.0 canary as @mauriciopoppe mentioned, and can run the promoter again..

@msau42
Copy link
Collaborator

msau42 commented Feb 4, 2022

Issue has been fixing by modifying the tag in the staging repo to match the hash that was promoted.

@msau42 msau42 closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants