fix: wrong targetPort type preventing service api calls

[sudopaeg]

No description provided.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhkimac
To complete the pull request process, please assign mbohlool
You can assign the PR to them by writing /assign @mbohlool in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @jhkimac!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[sudopaeg]

/assign @mbohlool

[drubin]

Hi, @jhkimac Thanks so much for this contribution!

Sadly we can't accept this as is, as this code is automatically generated from the openApi spec. So we need to fix it upstream in the generator or in the openApi spec.

See https://github.com/kubernetes-client/javascript#re-generating-code which calls https://github.com/kubernetes-client/javascript/blob/master/generate-client.sh

How does this fix it compared to the object value?

/assign @drubin

[sudopaeg]

Hi @drubin, I will try it out after a take a bit of rest. In the meantime, I have also found similar behavior in V1Container's V1Container.livenessProbe.httpGet.port, type enforcing object instead of number. I cannot find this problem in the openApi spec (or I am just too sleepy) at the moment. Will update after tomorrow.

[brendandburns]

This is discussed in #349 there's something weird going on with the Swagger and the code generator. It has to do with the way that IntOrString is represented in Swagger, and also what looks like it might be a bug in the code generator.

I've take a few attempts at fixing this, but it hasn't gone anywhere.

As @drubin says, we can't manually edit the code generated files.

[brendandburns]

Closing this PR since we can't merge it. Please continue discussion as needed in #349