Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request import in log.ts #275

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Fix request import in log.ts #275

merged 1 commit into from
Jun 12, 2019

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Jun 12, 2019

Use the TypeScript CommonJS-style import:

https://www.typescriptlang.org/docs/handbook/modules.html

because it looks like the request types use the CommonJS-style export:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/request/index.d.ts#L397

CC #274

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2019
@brendandburns
Copy link
Contributor

/lgtm
/approve

It's weird that our CI/CD didn't catch this...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, silasbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit cf992ee into kubernetes-client:master Jun 12, 2019
@drubin
Copy link
Contributor

drubin commented Jun 13, 2019

@brendanburns @silasbw any way we could make CI catch this type of error?

I feel like we can't rely on remembering all these different style imports to always get it right. I know that both @brendandburns and I sometimes refactor (in the past) the import style to be consistent.

@silasbw
Copy link
Contributor Author

silasbw commented Jun 13, 2019

i had a repro locally. it was specific to log.ts. i will spend a minute to see if i can convert that to a more holistic/inclusive CI test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants