deps: replace byline with node:readline
#1898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byline was being used to read a stream line by line. The core node:readline module appears to provide the functionality needed by this package, so remove an external dependency.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cjihrig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
cjihrig
commented
Sep 27, 2024
| @@ -1,5 +1,4 @@ | |||
| import byline = require('byline'); | |||
| import { RequestOptions } from 'https'; | |||
There was a problem hiding this comment.
This line is unrelated to this PR, but the code was unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bylinewas being used to read a stream line by line. The corenode:readlinemodule appears to provide the functionality needed by this package, so remove an external dependency.