Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hetzner private network #599

Closed
kron4eg opened this issue Jul 22, 2019 · 5 comments · Fixed by #627
Closed

Add support for hetzner private network #599

kron4eg opened this issue Jul 22, 2019 · 5 comments · Fixed by #627
Assignees
@xmudrii
Labels
sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@kron4eg
Copy link
Member

kron4eg commented Jul 22, 2019

Hetzner recently added support for private networking, would be good to extend machine-controller to support this.

This is how it looks like with new version of terraform hetzner provider: https://github.com/kubermatic/kubeone/pull/596/files#diff-8aec760bfdbb019e856b85fc10e43205
@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2019
@alvaroaleman alvaroaleman removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2019
@kubermatic kubermatic deleted a comment from kubermatic-bot Aug 2, 2019
@kdomanski kdomanski added sig/ui Denotes a PR or issue as being assigned to SIG UI. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. and removed sig/ui Denotes a PR or issue as being assigned to SIG UI. labels Aug 26, 2019
@xmudrii
Copy link
Member

xmudrii commented Aug 28, 2019

/assign

@xmudrii xmudrii mentioned this issue Aug 28, 2019
Merged
@kron4eg
Copy link
Member Author

kron4eg commented Aug 28, 2019

@xmudrii please keep in mind, hetzner didn't yet released a CCM with private networking support.

ref: hetznercloud/hcloud-cloud-controller-manager#19
ref: hetznercloud/hcloud-cloud-controller-manager#20

@alvaroaleman
Copy link
Contributor

@kron4eg Why is that of any relevance?

@xmudrii
Copy link
Member

xmudrii commented Aug 28, 2019

@kron4eg I'm aware of that but I believe that it shouldn't affect the machine-controller implementation. I'm still not sure how nodes are assigned IPs (i.e. internal and external IP), but AFAIK, machine-controller doesn't use CCM for that.

@kron4eg
Copy link
Member Author

kron4eg commented Aug 28, 2019

just telling :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmudrii xmudrii

Labels
sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Hetzner Private Networks kubermatic/machine-controller
5 participants
@kron4eg @kdomanski @alvaroaleman @xmudrii @kubermatic-bot