-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run e2e tests with Kubernetes version matrix #2266
Run e2e tests with Kubernetes version matrix #2266
Conversation
9b366cd
to
67f268b
Compare
/assign @ChenYi015 @ImpSy |
Makefile
Outdated
@@ -52,6 +52,7 @@ LOCALBIN ?= $(shell pwd)/bin | |||
KUSTOMIZE_VERSION ?= v5.4.1 | |||
CONTROLLER_TOOLS_VERSION ?= v0.15.0 | |||
KIND_VERSION ?= v0.23.0 | |||
KIND_K8S_VERSION ?= v1.31.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change default k8s version to v1.29.3 as we use now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep ENVTEST_K8S_VERSION
, KIND_K8S_VERSION
and the Go client versions in sync? If there's no dependency I'd prefer to use the latest minor version i.e. 1.31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should keep the three k8s versions the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 1.29.3
. I reckon we could bump to the latest minor at some point soon though. I don't think there are any APIs that either Spark or the operator are using that would block us, unless there are any kubebuilder/controller-runtime dependency issues.
67f268b
to
dca9238
Compare
Signed-off-by: Jacob Salway <[email protected]>
dca9238
to
c1789d4
Compare
I'll document the official |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Purpose of this PR
Change Category
Indicate the type of change by marking the applicable boxes:
Checklist