Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e tests with Kubernetes version matrix #2266

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Oct 19, 2024

Purpose of this PR

  • Run e2e tests with Kubernetes version matrix containing n-3 of the current Kubernetes versions

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway jacobsalway force-pushed the test-with-kubernetes-version-matrix branch from 9b366cd to 67f268b Compare October 19, 2024 06:54
@jacobsalway jacobsalway marked this pull request as ready for review October 19, 2024 07:19
@jacobsalway
Copy link
Member Author

/assign @ChenYi015 @ImpSy

Makefile Outdated
@@ -52,6 +52,7 @@ LOCALBIN ?= $(shell pwd)/bin
KUSTOMIZE_VERSION ?= v5.4.1
CONTROLLER_TOOLS_VERSION ?= v0.15.0
KIND_VERSION ?= v0.23.0
KIND_K8S_VERSION ?= v1.31.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change default k8s version to v1.29.3 as we use now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep ENVTEST_K8S_VERSION, KIND_K8S_VERSION and the Go client versions in sync? If there's no dependency I'd prefer to use the latest minor version i.e. 1.31

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should keep the three k8s versions the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 1.29.3. I reckon we could bump to the latest minor at some point soon though. I don't think there are any APIs that either Spark or the operator are using that would block us, unless there are any kubebuilder/controller-runtime dependency issues.

.github/workflows/integration.yaml Outdated Show resolved Hide resolved
.github/workflows/integration.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@jacobsalway jacobsalway force-pushed the test-with-kubernetes-version-matrix branch from 67f268b to dca9238 Compare October 22, 2024 03:35
@jacobsalway jacobsalway force-pushed the test-with-kubernetes-version-matrix branch from dca9238 to c1789d4 Compare October 22, 2024 06:09
@jacobsalway
Copy link
Member Author

I'll document the official n-3 (as governed by e2e test success) compatibility somewhere in a subsequent docs PR. I'd like to update the docs as mentioned during the community call.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 22, 2024
@google-oss-prow google-oss-prow bot merged commit 9f83e2a into kubeflow:master Oct 22, 2024
11 checks passed
@jacobsalway jacobsalway deleted the test-with-kubernetes-version-matrix branch October 22, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants