Skip to content

feat: workspace labels #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from
Open

feat: workspace labels #665

wants to merge 1 commit into from
+8 −3

Conversation

@thaorell
Copy link

closes: #232

Before
Screenshot 2025-10-14 at 10 20 30 AM

After
Screenshot 2025-10-24 at 6 03 51 PM

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Oct 24, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Oct 24, 2025
@google-oss-prow google-oss-prow bot requested review from ederign and paulovmr October 24, 2025 22:05
@google-oss-prow google-oss-prow bot added size/XS area/v2 area - version - kubeflow notebooks v2 labels Oct 24, 2025
@thaorell
Copy link
Author

thaorell commented Oct 30, 2025 •
edited
Loading

Screenshot 2025-10-30 at 11 30 04 AM

@paulovmr @caponetto @jenny-s51

@caponetto
Copy link

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 30, 2025
@paulovmr
Copy link

/ok-to-test

jenny-s51
jenny-s51 suggested changes Oct 30, 2025
View reviewed changes
Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thaorell - just one more nit below otherwise LGTM 🚀

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 30, 2025
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Oct 30, 2025
@thaorell thaorell requested a review from jenny-s51 October 30, 2025 17:51
paulovmr
paulovmr approved these changes Oct 30, 2025
View reviewed changes
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 30, 2025
jenny-s51
jenny-s51 approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks @thaorell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ederign ederign Awaiting requested review from ederign

@caponetto caponetto Awaiting requested review from caponetto

2 more reviewers

@paulovmr paulovmr paulovmr approved these changes

@jenny-s51 jenny-s51 jenny-s51 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@caponetto caponetto

@paulovmr paulovmr

@jenny-s51 jenny-s51

Labels

area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/S

Projects

Kubeflow Notebooks
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaorell @caponetto @paulovmr @jenny-s51