Skip to content

Commit a8f0094

Browse files
committed
fix wrapping behavior
1 parent 9409445 commit a8f0094

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

workspaces/frontend/src/app/components/WorkspaceTable.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ const {
6060
sortableKeyArray: sortableWsTableColumnKeyArray,
6161
filterableKeyArray: filterableWsTableColumnKeyArray,
6262
} = defineDataFields({
63-
name: { label: 'Name', isFilterable: true, isSortable: true, width: 25 },
64-
kind: { label: 'Kind', isFilterable: true, isSortable: true, width: 20 },
63+
name: { label: 'Name', isFilterable: true, isSortable: true, width: 35 },
64+
kind: { label: 'Kind', isFilterable: true, isSortable: true, width: 30 },
6565
namespace: { label: 'Namespace', isFilterable: true, isSortable: true, width: 15 },
66-
image: { label: 'Image', isFilterable: true, isSortable: true, width: 25 },
66+
image: { label: 'Image', isFilterable: true, isSortable: true, width: 30 },
6767
state: { label: 'State', isFilterable: true, isSortable: true, width: 15 },
6868
gpu: { label: 'GPU', isFilterable: true, isSortable: true, width: 15 },
6969
idleGpu: { label: 'Idle GPU', isFilterable: true, isSortable: true, width: 15 },
@@ -384,7 +384,7 @@ const WorkspaceTable = React.forwardRef<WorkspaceTableRef, WorkspaceTableProps>(
384384
key="workspace-table-column-name"
385385
sort={getSortParams('name')}
386386
aria-label="name"
387-
modifier="wrap"
387+
modifier="nowrap"
388388
>
389389
{wsTableColumns.name.label}
390390
</Th>
@@ -406,7 +406,7 @@ const WorkspaceTable = React.forwardRef<WorkspaceTableRef, WorkspaceTableProps>(
406406
key="workspace-table-column-kind"
407407
sort={getSortParams('kind')}
408408
aria-label="kind"
409-
modifier="wrap"
409+
modifier="nowrap"
410410
>
411411
{wsTableColumns.kind.label}
412412
</Th>
@@ -450,7 +450,6 @@ const WorkspaceTable = React.forwardRef<WorkspaceTableRef, WorkspaceTableProps>(
450450
key="workspace-table-column-idleGpu"
451451
sort={getSortParams('idleGpu')}
452452
aria-label="idleGpu"
453-
modifier="wrap"
454453
>
455454
{wsTableColumns.idleGpu.label}
456455
</Th>
@@ -461,7 +460,6 @@ const WorkspaceTable = React.forwardRef<WorkspaceTableRef, WorkspaceTableProps>(
461460
key="workspace-table-column-lastActivity"
462461
sort={getSortParams('lastActivity')}
463462
aria-label="lastActivity"
464-
modifier="wrap"
465463
>
466464
{wsTableColumns.lastActivity.label}
467465
</Th>

workspaces/frontend/src/app/pages/Workspaces/DataVolumesList.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,14 @@ export const DataVolumesList: React.FC<DataVolumesListProps> = ({ workspace }) =
4545
</Tooltip>
4646
)}
4747
</Content>
48-
<Content component="small">
49-
Mount path:{' '}
50-
<ClipboardCopy variant={ClipboardCopyVariant.inlineCompact}>
51-
{data.mountPath}
52-
</ClipboardCopy>
53-
</Content>
48+
<Flex gap={{ default: 'gapSm' }} flexWrap={{ default: 'wrap' }}>
49+
<FlexItem>Mount path:</FlexItem>
50+
<FlexItem>
51+
<ClipboardCopy variant={ClipboardCopyVariant.inlineCompact} isCode>
52+
{data.mountPath}
53+
</ClipboardCopy>
54+
</FlexItem>
55+
</Flex>
5456
</FlexItem>
5557
</Flex>
5658
);

workspaces/frontend/src/app/pages/Workspaces/ExpandedWorkspaceRow.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const ExpandedWorkspaceRow: React.FC<ExpandedWorkspaceRowProps> = ({
3838
{Array.from({ length: totalColumns }, (_, index) => {
3939
if (index === storageColumnIndex) {
4040
return (
41-
<Td key={`storage-${index}`} dataLabel="Storage">
41+
<Td key={`storage-${index}`} dataLabel="Storage" modifier="nowrap">
4242
<ExpandableRowContent>
4343
<WorkspaceStorage workspace={workspace} />
4444
</ExpandableRowContent>
@@ -48,7 +48,7 @@ export const ExpandedWorkspaceRow: React.FC<ExpandedWorkspaceRowProps> = ({
4848

4949
if (index === packageColumnIndex) {
5050
return (
51-
<Td key={`package-${index}`}>
51+
<Td key={`package-${index}`} modifier="nowrap">
5252
<ExpandableRowContent>
5353
<WorkspacePackageDetails workspace={workspace} />
5454
</ExpandableRowContent>
@@ -58,7 +58,7 @@ export const ExpandedWorkspaceRow: React.FC<ExpandedWorkspaceRowProps> = ({
5858

5959
if (index === configColumnIndex) {
6060
return (
61-
<Td key={`config-${index}`}>
61+
<Td key={`config-${index}`} modifier="nowrap">
6262
<ExpandableRowContent>
6363
<WorkspaceConfigDetails workspace={workspace} />
6464
</ExpandableRowContent>

0 commit comments

Comments
 (0)