Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Change to follow kubeflow/common convention and reuse implementation #72

Open
Jeffwan opened this issue Apr 14, 2020 · 2 comments
Open
Assignees

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Apr 14, 2020

Currently, mxnet operator API doesn't follow kubeflow/common convention and but controller does. It imports tf-operator implementation https://github.com/kubeflow/mxnet-operator/blob/c718707b304dc1ed0210a740c8efe7071d4ebb3e/pkg/controller.v1/mxnet/controller.go#L42

To graduate mxnet-operator to v1, we'd like to migrate to follow kubecom/common convention. It already has all the logic for ActiveDeadlineSeconds, BackoffLimit, etc. This will simplifies the implementation on mxnet-operator side.

@Jeffwan
Copy link
Member Author

Jeffwan commented Apr 14, 2020

Working on a PR to address this issue

@Jeffwan
Copy link
Member Author

Jeffwan commented Apr 14, 2020

/assign @Jeffwan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant