From 6572fd81a4a2366d3d15b8e6e9f567420a69147e Mon Sep 17 00:00:00 2001
From: Ricardo Martinelli de Oliveira <rmartine@redhat.com>
Date: Mon, 16 Oct 2023 12:38:59 -0300
Subject: [PATCH] Add env vars in kfp-driver to parametrize MLMD host and port

---
 .../v2/compiler/tektoncompiler/container.go   | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/backend/src/v2/compiler/tektoncompiler/container.go b/backend/src/v2/compiler/tektoncompiler/container.go
index d05979e687..c35d33273b 100644
--- a/backend/src/v2/compiler/tektoncompiler/container.go
+++ b/backend/src/v2/compiler/tektoncompiler/container.go
@@ -38,6 +38,8 @@ const (
 	MLPipelineServiceHost   = "ml-pipeline.kubeflow.svc.cluster.local"
 	MLPipelineServicePort   = "8887"
 	LauncherImage           = "gcr.io/ml-pipeline/kfp-launcher@sha256:80cf120abd125db84fa547640fd6386c4b2a26936e0c2b04a7d3634991a850a4"
+	MinioServiceHost        = "minio-service.kubeflow.svc.cluster.local"
+	MinioServicePort        = "9000"
 )
 
 var (
@@ -47,6 +49,8 @@ var (
 	mlPipelineServiceHost   = MLPipelineServiceHost
 	mlPipelineServicePort   = MLPipelineServicePort
 	launcherImage           = LauncherImage
+	minioServiceHost        = MinioServiceHost
+	minioServicePort        = MinioServicePort
 )
 
 func initEnvVars() {
@@ -70,11 +74,18 @@ func initEnvVars() {
 	if metadataGRPCServicePort == "" {
 		metadataGRPCServicePort = MetadataGPRCServicePort
 	}
-
 	launcherImage = os.Getenv("V2_LAUNCHER_IMAGE")
 	if launcherImage == "" {
 		launcherImage = LauncherImage
 	}
+	minioServiceHost = os.Getenv("MINIO_SERVICE_SERVICE_HOST")
+	if minioServiceHost == "" {
+		minioServiceHost = MinioServiceHost
+	}
+	minioServicePort = os.Getenv("MINIO_SERVICE_SERVICE_PORT")
+	if minioServicePort == "" {
+		minioServicePort = MinioServicePort
+	}
 	envVarInit = true
 }
 
@@ -438,6 +449,12 @@ func (c *pipelinerunCompiler) containerExecutorTemplate(
 					}, {
 						Name:  "ML_PIPELINE_SERVICE_PORT_GRPC",
 						Value: GetMLPipelinePort(),
+					}, {
+						Name:  "MINIO_SERVICE_SERVICE_HOST",
+						Value: GetMinioHost(),
+					}, {
+						Name:  "MINIO_SERVICE_SERVICE_PORT",
+						Value: GetMinioPort(),
 					}},
 				},
 			},