From c583c68a3b311bee25e575223ff6bcf3d33b5ab5 Mon Sep 17 00:00:00 2001 From: Bharath Krishna Date: Sun, 10 Mar 2024 11:55:49 -0700 Subject: [PATCH] py sdk create_exp - added type validation Signed-off-by: Bharath Krishna --- .../v1beta1/kubeflow/katib/api/katib_client.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py b/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py index 61f89056a31..2c2e0e4be57 100644 --- a/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py +++ b/sdk/python/v1beta1/kubeflow/katib/api/katib_client.py @@ -94,10 +94,15 @@ def create_experiment( namespace = namespace or self.namespace experiment_name = None - if experiment.metadata.name is not None: - experiment_name = experiment.metadata.name - elif experiment.metadata.generate_name is not None: - experiment_name = experiment.metadata.generate_name + if type(experiment) == models.V1beta1Experiment: + if experiment.metadata.name is not None: + experiment_name = experiment.metadata.name + elif experiment.metadata.generate_name is not None: + experiment_name = experiment.metadata.generate_name + elif "name" in experiment["metadata"]: + experiment_name = experiment["metadata"]["name"] + elif "generate_name" in experiment["metadata"]: + experiment_name = experiment["metadata"]["generate_name"] if experiment_name is None: raise ValueError("Experiment must have a name or generateName")