From 82215927e2c7b736edf779f6d604d5279947797d Mon Sep 17 00:00:00 2001 From: Ce Gao Date: Mon, 14 Oct 2019 12:42:05 -0500 Subject: [PATCH] feat: Add event when the reconcile is failed (#879) * feat: Add event when the reconcile is failed Signed-off-by: Ce Gao * fix: Use format Signed-off-by: Ce Gao --- pkg/controller.v1alpha3/trial/trial_controller.go | 3 +++ pkg/controller.v1alpha3/trial/trial_controller_consts.go | 1 + 2 files changed, 4 insertions(+) diff --git a/pkg/controller.v1alpha3/trial/trial_controller.go b/pkg/controller.v1alpha3/trial/trial_controller.go index 8ee6c69a845..2556f9a2f8f 100644 --- a/pkg/controller.v1alpha3/trial/trial_controller.go +++ b/pkg/controller.v1alpha3/trial/trial_controller.go @@ -179,6 +179,9 @@ func (r *ReconcileTrial) Reconcile(request reconcile.Request) (reconcile.Result, err := r.reconcileTrial(instance) if err != nil { logger.Error(err, "Reconcile trial error") + r.recorder.Eventf(instance, + corev1.EventTypeWarning, ReconcileFailedReason, + "Failed to reconcile: %v", err) return reconcile.Result{}, err } } diff --git a/pkg/controller.v1alpha3/trial/trial_controller_consts.go b/pkg/controller.v1alpha3/trial/trial_controller_consts.go index 0ab103a34d8..fee665616ce 100644 --- a/pkg/controller.v1alpha3/trial/trial_controller_consts.go +++ b/pkg/controller.v1alpha3/trial/trial_controller_consts.go @@ -17,4 +17,5 @@ const ( JobSucceededReason = "JobSucceeded" JobMetricsUnavailableReason = "MetricsUnavailable" JobFailedReason = "JobFailed" + ReconcileFailedReason = "ReconcileFailed" )