chore: remove unnecessary primer.css conflicting with minima theme #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tarilabs <[email protected]>
|
It looks better to me :-) |
|
fwiw it looks better to me too 🚀 /lgtm |
|
/lgtm Thanks Matteo! |
ederign
approved these changes
Jul 26, 2024
andreyvelich
approved these changes
Jul 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me use of primer.css (GitHub default's design system) conflicts with this blog's theme ("minima" customized) in some places, but most importantly unvisited links.
This result in being unable to distinguish in a blog post which are the available links (common in websites). Examples will be provided down below.
This PR proposes to remove primer.css imports to avoid said conflicts.
This PR is continued from: #150 (comment)
cc @StefanoFioravanzo @rimolive @juliusvonkohout wdyt?
Examples today Vs this_pr
as can be seen in Netlify preview in the action runs below.