Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-click request sizing ("apply") feature guide and API reference #201

Merged
merged 8 commits into from
May 3, 2022

Conversation

michaelmdresser
Copy link
Contributor

We don't have to merge this until we fully announce the feature, but I wanted to put it out for review so I can move on to other things.

@dwbrown2
Copy link
Contributor

Nice, here's initial feedback!

@michaelmdresser
Copy link
Contributor Author

Both done. I'll make an even stronger pitch for the feature when the frontend is ready to go -- I'll write a mini tutorial for using the new feature in UI and API, perhaps as a blog post.

This is an unfortunate limitation. I'd like to update it to not need
the secret so that some functionality can be unavailable.
@michaelmdresser
Copy link
Contributor Author

Good call. Clarified, let me know what you think.

@dwbrown2
Copy link
Contributor

dwbrown2 commented Mar 22, 2022

Good call. Clarified, let me know what you think.

Oh, I see why you added this comment now. Would be nice to make the service key optional later. That makes this much more work to run IMO.

@michaelmdresser
Copy link
Contributor Author

@dwbrown2
Copy link
Contributor

Reading this doc it feels hard to understand how to enable/use this feature... isn't it just this section that is required? https://github.com/kubecost/docs/blob/8f7f9cbc603f9e57a792e6a3762a4ac4457a401a/controller.md#deploying

Could we simplify? Here's an example that comes to mind:
https://guide.kubecost.com/hc/en-us/articles/4407595973527-Network-Traffic-Cost-Allocation

@michaelmdresser michaelmdresser changed the title First documentation for request sizing apply APIs 1-click request sizing ("apply") feature guide and API reference Apr 22, 2022
@michaelmdresser
Copy link
Contributor Author

@dwbrown2 I've now split the documentation here into an API reference and a how-to guide. Let me know what you think!

@michaelmdresser
Copy link
Contributor Author

As a general theory of documentation, I'm trying to roughly adhere to https://diataxis.fr/ -- this PR introduces "Reference" and "How-to guide" documentation. A blog probably falls in the "Tutorials" category.

Copy link
Contributor

@jessegoodier jessegoodier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Contributor

@srpomeroy srpomeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak.

guide-one-click-request-sizing.md Outdated Show resolved Hide resolved
@michaelmdresser michaelmdresser force-pushed the mmd/request-apply-api-docs branch from 724a4c1 to 6113226 Compare April 28, 2022 20:51
@teevans teevans merged commit 79f9c48 into main May 3, 2022
@michaelmdresser michaelmdresser deleted the mmd/request-apply-api-docs branch May 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants