-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-click request sizing ("apply") feature guide and API reference #201
Conversation
Nice, here's initial feedback!
|
Both done. I'll make an even stronger pitch for the feature when the frontend is ready to go -- I'll write a mini tutorial for using the new feature in UI and API, perhaps as a blog post. |
This is an unfortunate limitation. I'd like to update it to not need the secret so that some functionality can be unavailable.
Good call. Clarified, let me know what you think. |
Oh, I see why you added this comment now. Would be nice to make the service key optional later. That makes this much more work to run IMO. |
Service key will be optional when we merge: |
Reading this doc it feels hard to understand how to enable/use this feature... isn't it just this section that is required? https://github.com/kubecost/docs/blob/8f7f9cbc603f9e57a792e6a3762a4ac4457a401a/controller.md#deploying Could we simplify? Here's an example that comes to mind: |
@dwbrown2 I've now split the documentation here into an API reference and a how-to guide. Let me know what you think! |
As a general theory of documentation, I'm trying to roughly adhere to https://diataxis.fr/ -- this PR introduces "Reference" and "How-to guide" documentation. A blog probably falls in the "Tutorials" category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tweak.
724a4c1
to
6113226
Compare
We don't have to merge this until we fully announce the feature, but I wanted to put it out for review so I can move on to other things.