Remove duplicate 'RELEASE_NAME' env var #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mortenmj! We'll get this reviewed soon! |
|
This looks good to merge! @mortenmj out of curiosity, was running |
Correct. The output I got originally included the RELEASE_NAME env var twice. |
wolfeaustin
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This removes a duplicate environment variable in the Kubecost metrics deployment.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
The duplicate environment variable causes a crash when parsing the rendered Helm manifests with Jsonnet. Removing the duplicated value fixes this.
How was this PR tested?
Outputted manifests with
helm template. Ensured that RELEASE_NAME only appears once after this fix.Have you made an update to documentation?
N/A