Make cluster controller service key secret optional #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist.
AjayTripathy
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This smooths the adoption path for cluster controller features, like
1-click request sizing, that don't require service keys. Cluster
controller will be updated to gracefully handle situations where these
keys don't exist.
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Cluster controller will not require service account key to be set up in a secret for 1-click request sizing to be functional.
Links to Issues or ZD tickets this PR addresses or fixes
N/A
How was this PR tested?
See https://github.com/kubecost/cluster-controller/pull/6
Have you made an update to documentation?
Included in kubecost/docs#201