Don't use eq to default a possibly-nil value #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubecostModel.etlCloudAsset is nil by default. Before this change,
running helm template would give the following error:
Error: template: cost-analyzer/templates/cost-analyzer-deployment-template.yaml:533:19: executing "cost-analyzer/templates/cost-analyzer-deployment-template.yaml" at <eq .Values.kubecostModel.etlCloudAsset false>: error calling eq: incompatible types for comparison
After the change, the error is gone. Testing of the logic:
→ helm template ./cost-analyzer | grep -A 1 -i ETL_CLOUD
- name : ETL_CLOUD_USAGE_ENABLED
value: "false"
→ helm template ./cost-analyzer --set kubecostModel.etlCloudAsset=true | grep -A 1 -i ETL_CLOUD
- name : ETL_CLOUD_USAGE_ENABLED
value: "true"
|
Actually, @Sean-Holcomb should this default to true instead of false? I may have misread the current logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
kubecostModel.etlCloudAssetis nil by default. Before this change,running
helm templatewould give the following error:Error: template: cost-analyzer/templates/cost-analyzer-deployment-template.yaml:533:19: executing "cost-analyzer/templates/cost-analyzer-deployment-template.yaml" at <eq .Values.kubecostModel.etlCloudAsset false>: error calling eq: incompatible types for comparisonAfter the change, the error is gone.
cc @Sean-Holcomb does this maintain the default behavior you expect for this env var?
Does this PR rely on any other PRs?
N/A
How does this PR impact users? (This is the kind of thing that goes in release notes!)
N/A (I believe the current release doesn't have this issue, I assume this regressed in between the release and now.)
Links to Issues or ZD tickets this PR addresses or fixes
N/A
How was this PR tested?
Have you made an update to documentation?
N/A