Added in Customer Google Tag to values and environment variables #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancaburtoiu
approved these changes
Apr 15, 2022
dwbrown2
reviewed
Apr 15, 2022
| @@ -198,6 +198,8 @@ kubecostFrontend: | |||
| #limits: | |||
| # cpu: "100m" | |||
| # memory: "256Mi" | |||
| # customerGoogleTag allows you to embed your Google Global Site Tag to track usage of Kubecost. | |||
There was a problem hiding this comment.
@teevans sorry for catching this late, but what if we moved this under the reporting block? that's where all related analytics flags are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This add the GoogleCustomerTag value to the Values file in the helm chart under kubecostFrontend, and adds the GoogleCustomerTag as an environment variable to be returned by /getConfigs
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
This allows users to use their own Google Global Tag to track the utilization of their Kubecost frontend!
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Manually by deploying to my GKE cluster.
Have you made an update to documentation?
No - Will do prior to closing after we find out if I did this right.