Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Sidecar generating many log entires due to missing value #1412

Closed
srpomeroy opened this issue May 9, 2022 · 3 comments
Closed

Grafana Sidecar generating many log entires due to missing value #1412

srpomeroy opened this issue May 9, 2022 · 3 comments
Labels
bug Something isn't working v1.94

Comments

@srpomeroy
Copy link
Contributor

Describe the bug
When enabling the datasources feature of the Grafana sidecar, the logs fill up with an invalid literal error.

To Reproduce
Steps to reproduce the behavior:

  1. Enable the datasources feature of the Grafana Sidecar: https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/values.yaml#L666
  2. Observe logs

Expected behavior
SIdecar should run without error.

Screenshots
image

Collect logs (please complete the following information):
v1.92

image

@srpomeroy
Copy link
Contributor Author

The Grafana helm chart expects a value for .Values.sidecar.datasources.error_throttle_sleep.
By not setting it in our chart the value does not get set as an integer.

https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/charts/grafana/templates/deployment.yaml#L97

@Adam-Stack-PM
Copy link

@srpomeroy Can this issue be closed? Or are additional PRs needed?

PR #1413

@srpomeroy
Copy link
Contributor Author

We're good @AdamStack18 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.94
Projects
None yet
Development

No branches or pull requests

2 participants