feat(monitor): add an events channel to avoid event loss caused by delayed docker event processing #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashexx
changed the title
slashexx
changed the title
rksharma95
requested changes
Jan 20, 2025
There was a problem hiding this comment.
@slashexx Thanks for the PR, rest LGTM, just a few comments from my side. let me know wdyt?
slashexx
force-pushed
the
main
branch
3 times, most recently
from
3965d05 to
b660ad1
Compare
|
@slashexx can you please squash the commits? |
|
@rksharma95 commits have been squashed ! |
|
It's been open for a while, gentle ping @Prateeknandle @daemon1024 , is it gtg ? |
|
Hey @slashexx yep it mostly good to go. We currently have code freeze, only fixing bugs for upcoming stable release. We will start reviewing new PRs again after v1.5.1 release. Appreciate the PR! |
|
We will get this merged ASAP, Sorry for taking so long. Appreciate the contribution. |
Signed-off-by: slashexx <[email protected]> fix: update event options in Docker event stream to use ListOptions Signed-off-by: slashexx <[email protected]> refactor: remove unused import for Docker API types in dockerHandler Signed-off-by: slashexx <[email protected]> refactor: update GetEventChannel to accept context and stop channel for better event handling Signed-off-by: slashexx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1929
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
This PR addresses the Docker event queue buffer issue by adding processing logic in dockerHandler.go. It is part of improving KubeArmor's ability to handle high-frequency Docker events efficiently.
Checklist:
<type>(<scope>): <subject>