Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on supported k8s versions and how to pick them #19

Merged
merged 10 commits into from
Jun 19, 2022
Merged

Conversation

clux
Copy link
Member

@clux clux commented May 31, 2022

Kubernetes versioning docs (factored out of #18):

Done

Slightly iffy

  • Decide on our range, have set 5 to match upstream cloud provider stable support (which I think is pretty lenient, but less lenient than k8s-openapi)
  • talk about when we remove special abstractions around deprecated apis? (CRD/v1beta was removed when our range was [v1_19, v1_24], but it was actually removed from structs in v1_22`)
  • is it OK to have a MK8SV badge? see RENDERED README against upstream PR - seems OK (it links to the policy)

For the badge; we link to this policy document because it's unclear what a soft minimum means. MK8SV is always going to be a soft minimum, and what matters is how that range changes what you can expect. As a result, have also mentioned the stricter part about when we remove our own special abstractions (like CRD/v1beta1).

Unfortunately we cannot always test the maximum directly (k3s releases lagging as found in kube-rs/kube#924 ) but at least that PR does a good job of improving the situation.

clux added a commit that referenced this pull request May 31, 2022
clux added a commit to kube-rs/kube that referenced this pull request May 31, 2022
As part of Kubernetes version policies proposed in kube-rs/website#19
for #684

Signed-off-by: clux <[email protected]>
@clux clux marked this pull request as ready for review May 31, 2022 21:43
@clux clux requested review from kazk and nightkr May 31, 2022 21:44
@clux
Copy link
Member Author

clux commented May 31, 2022

Have factored this out of the general policy PR and cleaned it up a bit. It is kind of mergeable together with kube-rs/kube#924. But could use some thoughts on the points edited into the main PR.

@clux
Copy link
Member Author

clux commented Jun 18, 2022

OK, have added a small bit about how we can remove special abstractions when the upstream source removes them to avoid being forced into a double support period for things like CRD/v1beta1.

All in all, I am reasonably happy with this now. The policy, while a bit arbitrary is easy to implement, matches real world use cases (cloud providers), and it explains what to expect + our special cases.

Will merge later tomorrow unless there are no comments on this.

docs/kubernetes-version.md Outdated Show resolved Hide resolved
docs/kubernetes-version.md Outdated Show resolved Hide resolved
docs/kubernetes-version.md Outdated Show resolved Hide resolved
docs/kubernetes-version.md Outdated Show resolved Hide resolved
docs/kubernetes-version.md Outdated Show resolved Hide resolved
clux added 5 commits June 19, 2022 06:54
Co-authored-by: kazk <[email protected]>

Signed-off-by: Eirik A <[email protected]>
Co-authored-by: kazk <[email protected]>

Signed-off-by: Eirik A <[email protected]>
Co-authored-by: kazk <[email protected]>

Signed-off-by: Eirik A <[email protected]>
Co-authored-by: kazk <[email protected]>

Signed-off-by: Eirik A <[email protected]>
Co-authored-by: kazk <[email protected]>

Signed-off-by: Eirik A <[email protected]>
@clux
Copy link
Member Author

clux commented Jun 19, 2022

man, i am really bad with those capitalizations huh 😅

Thanks!

@clux clux merged commit 2175f99 into main Jun 19, 2022
@clux clux deleted the k8sver branch June 19, 2022 05:54
clux added a commit to kube-rs/kube that referenced this pull request Jun 19, 2022
* Run e2e tests against supported kubernetes versions

As part of Kubernetes version policies proposed in kube-rs/website#19
for #684

Signed-off-by: clux <[email protected]>

* add integration tests as specific job to run it against mk8sv

Signed-off-by: clux <[email protected]>

* rename tests and try to fix integration

Signed-off-by: clux <[email protected]>

* fix k3d args?

Signed-off-by: clux <[email protected]>

* fix e2e

Signed-off-by: clux <[email protected]>

* test against v1.19

Signed-off-by: clux <[email protected]>

* badge update

Signed-off-by: clux <[email protected]>

* s/MINK8SV/MK8SV

Signed-off-by: clux <[email protected]>

* Big e2e rework (WIP)

Now two e2e tests, and more feature combinations.

Signed-off-by: clux <[email protected]>

* avoid rustls local due to the issues

Signed-off-by: clux <[email protected]>

* split e2e tests into own file and clean up when to matrix

Signed-off-by: clux <[email protected]>

* running bump-k8s also bumps mk8sv

Signed-off-by: clux <[email protected]>

* avoid illegal anchors and add badge bumping

Signed-off-by: clux <[email protected]>

* better version checks for mk8sv and msrv on ci

Signed-off-by: clux <[email protected]>

* move some ci around for consistency in naming

Signed-off-by: clux <[email protected]>

* stray command

Signed-off-by: clux <[email protected]>

* fix syntax errors?

Signed-off-by: clux <[email protected]>

* fix test warning from kube-derive after apiext removal

Signed-off-by: clux <[email protected]>

* evars from tests

Signed-off-by: clux <[email protected]>

* better run description on integration jobs

Signed-off-by: clux <[email protected]>

* better output for flaky integration test

Signed-off-by: clux <[email protected]>

* fmt + give test more time?

Signed-off-by: clux <[email protected]>

* sanity after timeout. seems likely cause.

Signed-off-by: clux <[email protected]>

* no need for an agent in k3d cmd

Signed-off-by: clux <[email protected]>

* how slow is this actions cluster?

Signed-off-by: clux <[email protected]>

* re-trigger once more to check

* apiserver, are you ok?

Signed-off-by: clux <[email protected]>

* another empty commit to retrigger

Signed-off-by: clux <[email protected]>

* remove duplicate changes from #924

(won't build until that is merged)

Signed-off-by: clux <[email protected]>
clux added a commit that referenced this pull request Mar 5, 2023
Signed-off-by: clux <[email protected]>

link to future stability policy discussion

Signed-off-by: clux <[email protected]>

create a kubernetes versioning matrix now

since we can't use kubernetes versioning post 1.0, there's no point
waiting. let's define and get clarity now.

Signed-off-by: clux <[email protected]>

potential solution for kubernetes version policy

Propose a 5 version range from [MAX-4, MAX], since this matches kubernetes upstream support.
This will need to go with better e2e tests.

Signed-off-by: clux <[email protected]>

remove kubernetes doc - moved into #19

Signed-off-by: clux <[email protected]>

update with unstable features

Signed-off-by: clux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants