You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noting this comment, I've started work in this branch to replace run() and action with the contents of run_with_result() and action_with_result, i.e. run() and Action will always return a Result. This is a breaking change, so it would be good to increase the major version if this change is made.
Along with the above change, I think it would be good to treat FlagError and ActionError consistently by renaming the current FlagError to FlagErrorKind and creating a new FlagError type that is similar to ActionError.
@ksk001100 Do you agree with the above changes for v3.0.0? Also, is there anything else (especially possibly-breaking changes) that you think should be included in v3.0.0?
The text was updated successfully, but these errors were encountered:
Noting this comment, I've started work in this branch to replace
run()
andaction
with the contents ofrun_with_result()
andaction_with_result
, i.e.run()
andAction
will always return aResult
. This is a breaking change, so it would be good to increase the major version if this change is made.Along with the above change, I think it would be good to treat
FlagError
andActionError
consistently by renaming the currentFlagError
toFlagErrorKind
and creating a newFlagError
type that is similar toActionError
.@ksk001100 Do you agree with the above changes for
v3.0.0
? Also, is there anything else (especially possibly-breaking changes) that you think should be included inv3.0.0
?The text was updated successfully, but these errors were encountered: