Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 simplifications #80

Open
timburks opened this issue Dec 4, 2023 · 1 comment
Open

v3.0.0 simplifications #80

timburks opened this issue Dec 4, 2023 · 1 comment

Comments

@timburks
Copy link
Contributor

timburks commented Dec 4, 2023

Noting this comment, I've started work in this branch to replace run() and action with the contents of run_with_result() and action_with_result, i.e. run() and Action will always return a Result. This is a breaking change, so it would be good to increase the major version if this change is made.

Along with the above change, I think it would be good to treat FlagError and ActionError consistently by renaming the current FlagError to FlagErrorKind and creating a new FlagError type that is similar to ActionError.

@ksk001100 Do you agree with the above changes for v3.0.0? Also, is there anything else (especially possibly-breaking changes) that you think should be included in v3.0.0?

@ksk001100
Copy link
Owner

@timburks
I think that policy is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants