Move to CocoaPods 1.2.1 #300
Conversation
bundle install failed on my machine because I use ruby 2.4.1 and the json gem version 1.8.3 was not compatible. This problem has now been fixed: ruby/json#303
It is needed for the cocoapods-update-if-you-dare gem...
|
The Cocoapods update triggers a lot of changes to the project file after running I'm looking at them and may push the changes to this branch, or create a new pull-request. |
Generated by 🚫 Danger |
Gemfile
Outdated
| @@ -2,6 +2,7 @@ source 'https://rubygems.org' | |||
|
|
|||
| gem 'cocoapods' | |||
| gem 'cocoapods-update-if-you-dare', '~> 0.1.1' | |||
| gem 'colored' | |||
There was a problem hiding this comment.
I'm not sure if we need a new dependency here
There was a problem hiding this comment.
We actually do, since cocoapods-update-if-you-dare does not specify this dependency explicitly. And cocoapods moved to colored2: CocoaPods/Xcodeproj#463
I opened a PR on the project itself to fix it: Ashton-W/cocoapods-update-if-you-dare#2
There was a problem hiding this comment.
But if it's not released soon, the PR looks cool and we could merge it as is. Does it sound fine for you @garriguv ?
There was a problem hiding this comment.
Yeah that sounds good. I'll open another PR to remove colored once Ashton-W/cocoapods-update-if-you-dare#2 is merged and a new version of the gem is released.
There was a problem hiding this comment.
@garriguv I think there is no need for another PR. Just remove colored here from this one and update bundle once again and we're good to go 🚀
There was a problem hiding this comment.
Amazing, congratulations on your first contribution 🎉
I dared :) Also got rid of the colored dependency.
garriguv
force-pushed
the
garriguv/bundle-update
branch
from
84d0473
to
b8db04c
Compare
bundle install failed on my machine because I use ruby 2.4.1 and the
json gem version 1.8.3 was not compatible.
This problem has now been fixed:
ruby/json#303
While we're at it, why not update all the gems 😃
Since we're updating the gems, let's move to the latest CocoaPods as well.