ISerializable cleanup (dotnet#20220)

* Changes to throw PlatformNotSupportedException from ISerializable.GetObjectData and serialization constructors on non-serializable types. Also removes private serialization constructors and some unneeded code that was used to support serializing non-serializable types. A few tests testing GetObjectData implementations are also removed.

* Address code review comments.

* Change exceptions' GetObjectData to just call base rather than throw. This makes them behave consistently with exceptions that didn't override GetObjectData.

Author: morganbr

src/Common/src/System/Net/NetworkInformation/NetworkInformationException.cs

@@ -36,6 +36,7 @@ public NetworkInformationException(int errorCode) : base(errorCode)
 
         protected NetworkInformationException(SerializationInfo serializationInfo, StreamingContext streamingContext) : base(serializationInfo, streamingContext)
         {
+            throw new PlatformNotSupportedException();
         }
 
         internal NetworkInformationException(SocketError socketError) : base((int)socketError)

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderException.cs

@@ -49,6 +49,7 @@ public RuntimeBinderException(string message, Exception innerException)
         protected RuntimeBinderException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
+            throw new PlatformNotSupportedException();
         }
     }
 }

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderInternalCompilerException.cs

@@ -49,6 +49,7 @@ public RuntimeBinderInternalCompilerException(string message, Exception innerExc
         protected RuntimeBinderInternalCompilerException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
+            throw new PlatformNotSupportedException();
         }
     }
 }

src/Microsoft.Win32.Primitives/src/System/ComponentModel/Win32Exception.cs

@@ -63,17 +63,11 @@ public Win32Exception(string message, Exception innerException) : base(message,
 
         protected Win32Exception(SerializationInfo info, StreamingContext context) : base(info, context)
         {
-            nativeErrorCode = info.GetInt32(nameof(NativeErrorCode));
+            throw new PlatformNotSupportedException();
         }
 
         public override void GetObjectData(SerializationInfo info, StreamingContext context)
         {
-            if (info == null)
-            {
-                throw new ArgumentNullException(nameof(info));
-            }
-
-            info.AddValue(nameof(NativeErrorCode), nativeErrorCode);
             base.GetObjectData(info, context);
         }
 

src/Microsoft.Win32.Primitives/tests/Win32Exception.cs

@@ -101,12 +101,5 @@ public static void InstantiateExceptionWithLongErrorString()
                 Assert.Equal(expected: "Unknown error (0x23)", actual: ex.Message);
             }
         }
-
-        [Fact]
-        public static void GetObjectData_InvalidArgs_Throws()
-        {
-            var e = new Win32Exception();
-            AssertExtensions.Throws<ArgumentNullException>("info", () => e.GetObjectData(null, default(StreamingContext)));
-        }
     }
 }

src/System.CodeDom/src/System/CodeDom/CodeNamespace.cs

@@ -29,8 +29,6 @@ public CodeNamespace(string name)
             Name = name;
         }
 
-        private CodeNamespace(SerializationInfo info, StreamingContext context) { }
-
         public CodeTypeDeclarationCollection Types
         {
             get

src/System.CodeDom/src/System/CodeDom/Compiler/CodeDomProvider.cs

@@ -215,7 +215,10 @@ private ICodeParser CreateParserHelper()
         private sealed class ConfigurationErrorsException : SystemException
         {
             public ConfigurationErrorsException(string message) : base(message) { }
-            public ConfigurationErrorsException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+            public ConfigurationErrorsException(SerializationInfo info, StreamingContext context) : base(info, context)
+            {
+                throw new PlatformNotSupportedException();
+            }
         }
     }
 }

src/System.CodeDom/tests/CodeObjects/CodeNamespaceTests.cs

@@ -32,18 +32,6 @@ public void Ctor_String(string name)
 			Assert.Empty(codeNamespace.Comments);
 		}
 
-        [Fact]
-        [SkipOnTargetFramework(TargetFrameworkMonikers.UapAot, "Cannot do internal Reflection on framework types.")]
-        public void Ctor_SerializationInfo_StreamingContext()
-        {
-            ConstructorInfo constructor = typeof(CodeNamespace).GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, null, new Type[] { typeof(SerializationInfo), typeof(StreamingContext) }, null);
-            var codeNamespace = (CodeNamespace)constructor.Invoke(new object[] { default(SerializationInfo), default(StreamingContext) });
-            Assert.Empty(codeNamespace.Name);
-            Assert.Empty(codeNamespace.Types);
-            Assert.Empty(codeNamespace.Imports);
-            Assert.Empty(codeNamespace.Comments);
-        }
-
 		[Theory]
 		[MemberData(nameof(String_TestData))]
 		public void Name_Set_Get_ReturnsExpected(string value)

src/System.Collections.Specialized/src/System/Collections/Specialized/NameObjectCollectionBase.cs

@@ -21,6 +21,7 @@ namespace System.Collections.Specialized
     ///    and <see cref='System.Object' qualify='true'/> values that can be accessed either with the hash code of
     ///    the key or with the index.</para>
     /// </devdoc>
+    [Serializable]
     public abstract class NameObjectCollectionBase : ICollection, ISerializable, IDeserializationCallback
     {
         // const names used for serialization

src/System.Collections/src/System/Collections/Generic/LinkedList.cs

@@ -563,12 +563,7 @@ internal Enumerator(LinkedList<T> list)
 
             private Enumerator(SerializationInfo info, StreamingContext context)
             {
-                _siInfo = info;
-                _list = null;
-                _version = 0;
-                _node = null;
-                _current = default(T);
-                _index = 0;
+                throw new PlatformNotSupportedException();
             }
 
             public T Current
@@ -630,15 +625,7 @@ public void Dispose()
 
             void ISerializable.GetObjectData(SerializationInfo info, StreamingContext context)
             {
-                if (info == null)
-                {
-                    throw new ArgumentNullException(nameof(info));
-                }
-
-                info.AddValue(LinkedListName, _list);
-                info.AddValue(VersionName, _version);
-                info.AddValue(CurrentValueName, _current);
-                info.AddValue(IndexName, _index);
+                throw new PlatformNotSupportedException();
             }
 
             void IDeserializationCallback.OnDeserialization(Object sender)