Merge pull request #14 from flippidippi/master

Switch to using `--version` by default
kruppel · Nov 1, 2022 · 546d05e · 546d05e
2 parents 071d078 + 9ab347f
commit 546d05e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # check-engines [![Build Status](https://secure.travis-ci.org/kruppel/check-engines.svg?branch=master)](https://travis-ci.org/kruppel/check-engines)
 
-Utility to verify that engine versions (node, npm, iojs, yarn) satisfy semver
-constraints specified in package.json.
+Utility to verify that engine versions (node, npm, iojs, yarn, dotnet, etc.) satisfy semver
+constraints specified in `package.json`.
 
 ## Usage
 

diff --git a/lib/engine-test.js b/lib/engine-test.js
@@ -2,10 +2,6 @@ var crossSpawn = require('cross-spawn');
 var format = require('util').format;
 var semver = require('semver');
 
-var ENGINE_TEST_ARGS = {
-  yarn: '--version'
-};
-
 function EngineTest(type) {
   this.type = type;
   this.isNode = type === 'node' || type === 'iojs';
@@ -51,8 +47,7 @@ EngineTest.prototype.getVersion = function(callback) {
   }
 
   var result = '';
-  var flag = ENGINE_TEST_ARGS[this.type] || '-v';
-  var version = crossSpawn.spawn(this.type, [flag], {shell: true});
+  var version = crossSpawn.spawn(this.type, ['--version'], {shell: true});
 
   version.stdout.on('data', function(data) {
     result += data.toString();

diff --git a/spec/check-engines_spec.js b/spec/check-engines_spec.js
@@ -28,7 +28,7 @@ describe('check-engines', function() {
   beforeEach(function() {
     mockChildProcess = new MockChildProcess();
     sinon.stub(crossSpawn, 'spawn');
-    crossSpawn.spawn.withArgs('npm', ['-v'], {shell: true})
+    crossSpawn.spawn.withArgs('npm', ['--version'], {shell: true})
       .returns(mockChildProcess);
   });
 
@@ -195,7 +195,7 @@ describe('check-engines', function() {
       var invalidCommandMock = new MockChildProcess();
 
       crossSpawn.spawn.withArgs(
-        'this-is-not-an-executable', ['-v']
+        'this-is-not-an-executable', ['--version']
       ).returns(invalidCommandMock);
 
       process.nextTick(function() {