Make max panorama size user selectable (#129)

* Make max panorama size user selectable

* Fix formatting

* Make clang-tidy happy

Author: Altonss

xpano/algorithm/algorithm.cc

@@ -260,6 +260,7 @@ StitchResult Stitch(const std::vector<cv::Mat>& images,
       false, user_options.match_conf));
   stitcher->SetWaveCorrection(user_options.wave_correction !=
                               WaveCorrectionType::kOff);
+  stitcher->SetMaxPanoSize(user_options.max_pano_size);
   if (stitcher->WaveCorrection()) {
     stitcher->SetWaveCorrectKind(
         PickWaveCorrectKind(user_options.wave_correction));

xpano/algorithm/options.h

@@ -84,6 +84,7 @@ struct StitchUserOptions {
   FeatureType feature = FeatureType::kSift;
   WaveCorrectionType wave_correction = WaveCorrectionType::kAuto;
   float match_conf = kDefaultMatchConf;
+  int max_pano_size = kMaxPanoSize;
   BlendingMethod blending_method = kDefaultBlendingMethod;
 };
 

xpano/algorithm/stitcher.cc

@@ -291,9 +291,9 @@ Status Stitcher::ComposePanorama(cv::OutputArray pano) {
   }
   auto dst_roi = cv::detail::resultRoi(corners, sizes);
 
-  if (dst_roi.width >= kMaxPanoSize || dst_roi.height >= kMaxPanoSize) {
+  if (dst_roi.width >= max_pano_size_ || dst_roi.height >= max_pano_size_) {
     spdlog::error("Panorama is too large to compute: {}x{}, max size is {}",
-                  dst_roi.width, dst_roi.height, kMaxPanoSize);
+                  dst_roi.width, dst_roi.height, max_pano_size_);
     return Status::kErrPanoTooLarge;
   }
 

xpano/algorithm/stitcher.h

@@ -135,6 +135,9 @@ class Stitcher {
     features_matcher_ = features_matcher;
   }
 
+  [[nodiscard]] int MaxPanoSize() const { return max_pano_size_; }
+  void SetMaxPanoSize(int max_pano_size) { max_pano_size_ = max_pano_size; }
+
   [[nodiscard]] const cv::UMat& MatchingMask() const { return matching_mask_; }
   void SetMatchingMask(const cv::UMat& mask) {
     CV_Assert(mask.type() == CV_8U && mask.cols == mask.rows);
@@ -272,6 +275,7 @@ class Stitcher {
 
   ProgressMonitor* monitor_ = nullptr;
   WarpHelper warp_helper_ = {};
+  int max_pano_size_;
 };
 
 }  // namespace xpano::algorithm::stitcher

xpano/constants.h

@@ -103,6 +103,7 @@ constexpr int kCancelAnimationFrameDuration = 128;
 const std::string kGithubIssuesLink = "https://github.com/krupkat/xpano/issues";
 const std::string kAuthorEmail = "[email protected]";
 
-const int kMaxPanoSize = 16384;
+constexpr int kMaxPanoSize = 16384;
+constexpr int kMaxPanoSizeStep = 256;
 
 }  // namespace xpano

xpano/gui/panels/sidebar.cc

@@ -330,6 +330,18 @@ Action DrawBlendingOptions(pipeline::StitchAlgorithmOptions* stitch_options) {
   return action;
 }
 
+Action DrawMaxPanoSizeOptions(
+    pipeline::StitchAlgorithmOptions* stitch_options) {
+  Action action{};
+  ImGui::Text("Max panorama size:");
+  ImGui::Spacing();
+  if (ImGui::InputInt("Max panorama size", &stitch_options->max_pano_size,
+                      kMaxPanoSizeStep)) {
+    action |= {ActionType::kRecomputePano};
+  }
+  return action;
+}
+
 Action DrawStitchOptionsMenu(pipeline::StitchAlgorithmOptions* stitch_options,
                              bool debug_enabled) {
   Action action{};
@@ -340,6 +352,7 @@ Action DrawStitchOptionsMenu(pipeline::StitchAlgorithmOptions* stitch_options,
     if (debug_enabled) {
       ImGui::SeparatorText("Debug");
       action |= DrawBlendingOptions(stitch_options);
+      action |= DrawMaxPanoSizeOptions(stitch_options);
       action |= DrawFeatureMatchingOptions(stitch_options);
 
       if (DrawMatchConf(&stitch_options->match_conf)) {