PHP 8.3 (#166)

Author: etremblay

.github/workflows/php.yml

@@ -17,3 +17,12 @@ jobs:
       extensions: pcov
     secrets:
       GPR_KEY: ${{ secrets.GPR_KEY }}
+
+  php-library-8-3:
+    uses: equisoft-actions/php-workflows/.github/workflows/php-library.yml@v4
+    with:
+      checks: phpunit,psalm
+      php-version: '8.3'
+      extensions: pcov
+    secrets:
+      GPR_KEY: ${{ secrets.GPR_KEY }}

qodana.yaml

@@ -1,8 +1,8 @@
 version: "1.0"
-linter: jetbrains/qodana-php:2022.2-eap
+linter: jetbrains/qodana-php:2023.3-eap
 
 script:
   name: php-migration
   parameters:
-      fromLevel: 7.4
-      toLevel: 8.1
+    fromLevel: 8.1
+    toLevel: 8.3

tests/Writer/FluentdTest.php

@@ -179,7 +179,7 @@ public function test_WrapContextInMeta_log_UnderlyingMetaDoesNotContainLevelOrMe
         $this->logger->expects($this->once())
             ->method('post')
             ->with($this->anything(), $this->callback(function ($value) use ($givenApp) {
-                return $value['meta']['level'] === null && $value['meta']['message'] === null;
+                return empty($value['meta']['level']) && empty($value['meta']['message']);
             }));
 
         $this->writer->log(LogLevel::INFO, "test");
@@ -219,13 +219,13 @@ public function test_ExceptionWhenLogging_log_ReturnsFalse()
         $this->logger->method('post')->willThrowException(new \Exception("Connection error"));
         $this->writer = new Fluentd("localhost", 24224, "test", null, false, $this->factory);
 
-        $this->writer->log(LogLevel::INFO, "test");
-
         $h = false;
-        set_error_handler(function () use (&$h) {
+        set_error_handler(static function () use (&$h) {
             $h = true;
         }, E_USER_WARNING);
+
         $retVal = $this->writer->log(LogLevel::INFO, "Anything");
+        restore_error_handler();
         $this->assertTrue($h);
 
         $this->assertFalse($retVal);