Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown-list): prevents error when explicit value is not in options #892

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

ogermain-kronos
Copy link
Contributor

https://equisoft.atlassian.net/browse/DS-1158

Lors de l'implémentation du dropdown-list dans le CRM, on a trouvé un bug qui fait planter le component si la valeur de la prop value n'est pas comprise dans l'array d'options.

Normalement, il devrait simplement afficher aucune option, et non planter.

Facilement reproductible dans le Storybook:

export const WithoutSelectedOptions: Story = () => (
    <DropdownList
        data-testid="blip-bloop"
        options={[]}
        value={'test'}
    />
);

@ogermain-kronos ogermain-kronos requested a review from a team June 3, 2024 12:45
@ogermain-kronos ogermain-kronos requested a review from a team as a code owner June 3, 2024 12:45
Copy link

github-actions bot commented Jun 3, 2024

Storybook for this build: https://ds.equisoft.io/pr-892/

Copy link

github-actions bot commented Jun 3, 2024

Webapp for this build: https://ds.equisoft.io/pr-892/webapp/

@ogermain-kronos ogermain-kronos merged commit e39af5e into master Jun 3, 2024
23 checks passed
@ogermain-kronos ogermain-kronos deleted the dev/DS-1158 branch June 3, 2024 13:31
pylafleur pushed a commit that referenced this pull request Jun 3, 2024
…ons (#892)

* fix(dropdown-list): prevents error when explicit value is not in options
meriouma pushed a commit that referenced this pull request Jun 4, 2024
…ons (#892)

* fix(dropdown-list): prevents error when explicit value is not in options
meriouma pushed a commit that referenced this pull request Jun 4, 2024
…ons (#892)

* fix(dropdown-list): prevents error when explicit value is not in options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants