-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown-list): prevents error when explicit value is not in options #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogermain-kronos
temporarily deployed
to
github-pages
June 3, 2024 12:49
— with
GitHub Actions
Inactive
Storybook for this build: https://ds.equisoft.io/pr-892/ |
ogermain-kronos
temporarily deployed
to
github-pages
June 3, 2024 12:49
— with
GitHub Actions
Inactive
Webapp for this build: https://ds.equisoft.io/pr-892/webapp/ |
mmorin-equisoft
previously approved these changes
Jun 3, 2024
ogermain-kronos
temporarily deployed
to
github-pages
June 3, 2024 13:15
— with
GitHub Actions
Inactive
ogermain-kronos
temporarily deployed
to
github-pages
June 3, 2024 13:15
— with
GitHub Actions
Inactive
mmorin-equisoft
approved these changes
Jun 3, 2024
savutsang
approved these changes
Jun 3, 2024
pylafleur
pushed a commit
that referenced
this pull request
Jun 3, 2024
…ons (#892) * fix(dropdown-list): prevents error when explicit value is not in options
meriouma
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ons (#892) * fix(dropdown-list): prevents error when explicit value is not in options
meriouma
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ons (#892) * fix(dropdown-list): prevents error when explicit value is not in options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://equisoft.atlassian.net/browse/DS-1158
Lors de l'implémentation du
dropdown-list
dans le CRM, on a trouvé un bug qui fait planter le component si la valeur de la propvalue
n'est pas comprise dans l'array d'options.Normalement, il devrait simplement afficher aucune option, et non planter.
Facilement reproductible dans le Storybook: