Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all icons from icons.ts (conversionType==='constants') #132

Closed
Guzel738 opened this issue Sep 24, 2021 · 3 comments · Fixed by #153
Closed

Export all icons from icons.ts (conversionType==='constants') #132

Guzel738 opened this issue Sep 24, 2021 · 3 comments · Fixed by #153

Comments

@Guzel738
Copy link

Environment

  • Angular 12;
  • svg-to-ts 6.0.2.

Problem

In the second approach to converse types (conversionType==='constants'), generated file icons.ts doesn`t contain export of all icons. So everytime we add new icon in method registerIcons() and we need to add this icon to the import list.

It should be better to have singe export with all constants as : export const all = [icon1, icon2, ...].

Would it be possible to add this functionality?

@nivekcode
Copy link
Owner

Yes, that would make perfect sense. I will try to add this feature once I find the time.

@nivekcode
Copy link
Owner

Hi @Guzel738 with version 8.3 a complete icon set gets generated by default when using the constant conversion type

nivekcode pushed a commit that referenced this issue Feb 4, 2022
# [8.3.0](v8.2.0...v8.3.0) (2022-02-04)

### Bug Fixes

* **configoptions:** add export complete icon set as config options ([6df1b7e](6df1b7e))

### Features

* **constants:** export all generated constants by default and add configuration option ([cd43dcb](cd43dcb)), closes [#132](#132)
@Guzel738
Copy link
Author

Guzel738 commented Feb 5, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants