Skip to content

Commit 9052b44

Browse files
committed
feat(converter): fix default typeName + use it in options collector
1 parent e9c6194 commit 9052b44

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"start-object:upper": "ts-node ./src/bin/svg-to-ts.ts-object -s 'inputfiles-hyphen/*.svg' -d UPPER",
2323
"start-object:multiple-source": "ts-node ./src/bin/svg-to-ts-object -s './inputfilesRegex/laughing/laughing.svg' -s 'inputfilesRegex/expressionLess/expressionLess.svg'",
2424
"start-object:custom": "ts-node ./src/bin/svg-to-ts-object -s './inputfiles/*.svg' -o ./dist --objectName awesomeIcons -f icons",
25-
"start-object:generateType": "ts-node ./src/bin/svg-to-ts-object -s './inputfiles/*.svg' -o ./dist --objectName awesomeIcons --typeName MyType",
25+
"start-object:generateType": "ts-node ./src/bin/svg-to-ts-object -s './inputfiles/*.svg' -o ./dist --objectName awesomeIcons --typeName MyIconType",
2626
"start-object:export-const": "ts-node ./src/bin/svg-to-ts-object.ts -s './inputfiles/*.svg' -o ./dist --objectName myIcons",
2727
"start-constants": "ts-node ./src/bin/svg-to-ts-constants.ts -s './inputfiles/*.svg'",
2828
"start-constants:help": "ts-node ./src/bin/svg-to-ts-constants.ts --help'",

src/lib/options/default-options/default-object-conversion-options.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ export const DEFAULT_OBJECT_CONVERSION_OPTIONS: ObjectConversionOptions = {
99
fileName: 'my-icons',
1010
objectName: 'icons',
1111
generateType: true,
12-
typeName: 'MyType'
12+
typeName: 'MyIconType'
1313
};

src/lib/options/options-collector/command-line-options-collectors/commandline-object-options.collector.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import commander from 'commander';
22

33
import { getSvgoConfig } from '../../../helpers/svg-optimization';
44
import { ObjectConversionOptions } from '../../conversion-options/object-conversion-options';
5-
import { DEFAULT_CONST_CONVERSION_OPTIONS } from '../../default-options/default-constants-conversion-options';
65
import { DEFAULT_OBJECT_CONVERSION_OPTIONS } from '../../default-options/default-object-conversion-options';
76

87
import { toBoolean } from './command-line-collector.helpers';
@@ -11,7 +10,7 @@ export const collectCommandLineObjectOptions = async (): Promise<ObjectConversio
1110
let { objectName, delimiter, fileName, outputDirectory, verbose, generateType, typeName } = commander;
1211
let svgoConfig = commander.svgoConfig;
1312

14-
generateType = toBoolean(generateType, DEFAULT_CONST_CONVERSION_OPTIONS.generateType);
13+
generateType = toBoolean(generateType, DEFAULT_OBJECT_CONVERSION_OPTIONS.generateType);
1514

1615
// Parse boolean values
1716
verbose = toBoolean(verbose, DEFAULT_OBJECT_CONVERSION_OPTIONS.verbose);

0 commit comments

Comments
 (0)