From 60df4e1e37a1ab8e770686bc3de100124f7420fc Mon Sep 17 00:00:00 2001 From: Nigro Simone Date: Fri, 25 Apr 2025 20:40:00 +0200 Subject: [PATCH] perf: improve buildData by preallocating array --- .../keyed/angular-cf-new-nozone/src/app/app.component.ts | 7 +++---- .../keyed/angular-cf-nozone/src/app/app.component.ts | 7 +++---- frameworks/keyed/angular-cf/src/app/app.component.ts | 7 +++---- frameworks/keyed/angular-ngfor/src/app/app.component.ts | 7 +++---- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/frameworks/keyed/angular-cf-new-nozone/src/app/app.component.ts b/frameworks/keyed/angular-cf-new-nozone/src/app/app.component.ts index cee0c10cb..b958d8b1b 100644 --- a/frameworks/keyed/angular-cf-new-nozone/src/app/app.component.ts +++ b/frameworks/keyed/angular-cf-new-nozone/src/app/app.component.ts @@ -25,10 +25,9 @@ export class AppComponent { version = VERSION.full; buildData(count: number = 1000): Array { - var data: Array = new Array(count); - for (var i = 0; i < count; i++) { - data[i]={ id: this.id, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; - this.id++; + const data: Array = new Array(count); + for (let i = 0; i < count; i++) { + data[i]={ id: this.id++, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; } return data; } diff --git a/frameworks/keyed/angular-cf-nozone/src/app/app.component.ts b/frameworks/keyed/angular-cf-nozone/src/app/app.component.ts index 9d963936a..c44bd0d49 100644 --- a/frameworks/keyed/angular-cf-nozone/src/app/app.component.ts +++ b/frameworks/keyed/angular-cf-nozone/src/app/app.component.ts @@ -23,10 +23,9 @@ export class AppComponent { version = VERSION.full; buildData(count: number = 1000): Array { - var data: Array = []; - for (var i = 0; i < count; i++) { - data.push({ id: this.id, label: adjectives[this._random(adjectives.length)] + " " + colours[this._random(colours.length)] + " " + nouns[this._random(nouns.length)] }); - this.id++; + const data: Array = new Array(count); + for (let i = 0; i < count; i++) { + data[i] = { id: this.id++, label: adjectives[this._random(adjectives.length)] + " " + colours[this._random(colours.length)] + " " + nouns[this._random(nouns.length)] }; } return data; } diff --git a/frameworks/keyed/angular-cf/src/app/app.component.ts b/frameworks/keyed/angular-cf/src/app/app.component.ts index 349c77cc0..bb9df93a8 100644 --- a/frameworks/keyed/angular-cf/src/app/app.component.ts +++ b/frameworks/keyed/angular-cf/src/app/app.component.ts @@ -24,10 +24,9 @@ export class AppComponent { version = VERSION.full; buildData(count: number = 1000): Array { - var data: Array = new Array(count); - for (var i = 0; i < count; i++) { - data[i]={ id: this.id, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; - this.id++; + const data: Array = new Array(count); + for (let i = 0; i < count; i++) { + data[i]={ id: this.id++, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; } return data; } diff --git a/frameworks/keyed/angular-ngfor/src/app/app.component.ts b/frameworks/keyed/angular-ngfor/src/app/app.component.ts index 349c77cc0..bb9df93a8 100644 --- a/frameworks/keyed/angular-ngfor/src/app/app.component.ts +++ b/frameworks/keyed/angular-ngfor/src/app/app.component.ts @@ -24,10 +24,9 @@ export class AppComponent { version = VERSION.full; buildData(count: number = 1000): Array { - var data: Array = new Array(count); - for (var i = 0; i < count; i++) { - data[i]={ id: this.id, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; - this.id++; + const data: Array = new Array(count); + for (let i = 0; i < count; i++) { + data[i]={ id: this.id++, label: `${adjectives[this._random(adjectives.length)]} ${colours[this._random(colours.length)]} ${nouns[this._random(nouns.length)]}` }; } return data; }