Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update updateState.ts #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/middlewares/updateState.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
import { QContext } from "../../index";
import { undefinedOrTrue } from "../utils";

export default function updateState(context: QContext, done) {
if (undefinedOrTrue(context.navigateOptions, "updateState")) {
context.instance._setCurrent(context.matches);
export default function updateState(context: QContext, done: () => void) {
const { navigateOptions, instance, matches } = context;

if (undefinedOrTrue(navigateOptions, "updateState")) {
instance._setCurrent(matches);
}
done();

// We call the next function in the middleware chain with a delay, to give
// time for the state to be updated in the browser's history API. This is
// necessary to prevent the `_matchRoute` function from being called with
// the old state in certain scenarios, such as when using the back button
// or when navigating to the same URL twice in a row.
setTimeout(() => {
done();
}, 10);
}