fix: not compiling histogram bucket vars

Author: dhontecillas

http/client/transport_metrics.go

@@ -12,14 +12,14 @@ import (
 var (
 	// TODO: we can tweak the level of detail for the time buckets:
 	// this will generate 20 time series for the metric
-	timeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	timeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0.010, 0.020, 0.030, 0.040,
 		0.050, 0.065, 0.080, 0.100,
 		0.150, 0.200, 0.250, 0.300,
 		0.500, 0.750, 1.000, 1.500,
 		2.000, 5.000, 10.000)
 
-	sizeBucketOpt := metric.WithExplicitBucketBoundaries(
+	sizeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0, 256, 512, 1024, // <- reasonable response sizes
 		4*1024, 8*1024, 16*1024, 32*1024, // <- these starts to be big
 		64*1024, 4*64*1024, 8*64*1024, 16*64*1024, // <- those are huge for an api response 64k to 1 Meg
@@ -81,14 +81,14 @@ func newTransportMetrics(metricsOpts *TransportMetricsOptions, meter metric.Mete
 
 	tm.requestContentLength, _ = meter.Int64Counter("requests-content-length") // the value of the Content-Length header for the request
 
-	tm.responseLatency, _ = meter.Float64Histogram("response-latency", timeBucketsOpts)
+	tm.responseLatency, _ = meter.Float64Histogram("response-latency", timeBucketsOpt)
 
-	tm.responseContentLength, _ = meter.Int64Histogram("response-content-length", sizeBucketOpt)
+	tm.responseContentLength, _ = meter.Int64Histogram("response-content-length", sizeBucketsOpt)
 
 	tm.detailsEnabled = metricsOpts.DetailedConnection
 	tm.getConnLatency, _ = meter.Float64Histogram("request-get-conn-latency", timeBucketsOpt)
-	tm.dnsLatency, _ = meter.Float64Histogram("request-dns-latency", timeBucketOpt)
-	tm.tlsLatency, _ = meter.Float64Histogram("request-tls-latency", timeBucketOpt)
+	tm.dnsLatency, _ = meter.Float64Histogram("request-dns-latency", timeBucketsOpt)
+	tm.tlsLatency, _ = meter.Float64Histogram("request-tls-latency", timeBucketsOpt)
 	return &tm
 }
 

io/instruments.go

@@ -17,14 +17,14 @@ var (
 
 	// TODO: we can tweak the level of detail for the time buckets:
 	// this will generate 20 time series for the metric
-	timeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	timeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0.010, 0.020, 0.030, 0.040,
 		0.050, 0.065, 0.080, 0.100,
 		0.150, 0.200, 0.250, 0.300,
 		0.500, 0.750, 1.000, 1.500,
 		2.000, 5.000, 10.000)
 
-	sizeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	sizeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0, 256, 512, 1024, // <- reasonable response sizes
 		4*1024, 8*1024, 16*1024, 32*1024, // <- these starts to be big
 		64*1024, 4*64*1024, 8*64*1024, 16*64*1024, // <- those are huge for an api response 64k to 1 Meg
@@ -97,7 +97,7 @@ func newInstruments(prefix string,
 		if bsc, err := meter.Int64Counter(strSizeCount, metric.WithUnit("b")); err == nil {
 			sizeCount = bsc
 		}
-		if bsh, err := meter.Int64Histogram(strSizeHistogram, sizeBucketOpt, metric.WithUnit("b")); err == nil {
+		if bsh, err := meter.Int64Histogram(strSizeHistogram, sizeBucketsOpt, metric.WithUnit("b")); err == nil {
 			sizeHistogram = bsh
 		}
 		if brtc, err := meter.Float64Counter(strTimeCount, metric.WithUnit("s")); err == nil {

lura/proxy.go

@@ -19,14 +19,14 @@ import (
 var (
 	// TODO: we can tweak the level of detail for the time buckets:
 	// this will generate 20 time series for the metric
-	timeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	timeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0.010, 0.020, 0.030, 0.040,
 		0.050, 0.065, 0.080, 0.100,
 		0.150, 0.200, 0.250, 0.300,
 		0.500, 0.750, 1.000, 1.500,
 		2.000, 5.000, 10.000)
 
-	sizeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	sizeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0, 256, 512, 1024, // <- reasonable response sizes
 		4*1024, 8*1024, 16*1024, 32*1024, // <- these starts to be big
 		64*1024, 4*64*1024, 8*64*1024, 16*64*1024, // <- those are huge for an api response 64k to 1 Meg

router/gin/endpoint_metrics.go

@@ -6,21 +6,21 @@ import (
 	"go.opentelemetry.io/otel/semconv/v1.21.0"
 )
 
-// TODO: we must decide if we want a single shared configuration of the 
+// TODO: we must decide if we want a single shared configuration of the
 // time buckets, and the size buckets, or if we want to be able to tweak
 // the buckets for each layer (or give some options, like low / medium / high
 // detail that would add more or less buckets).
 var (
 	// TODO: we can tweak the level of detail for the time buckets:
 	// this will generate 20 time series for the metric
-	timeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	timeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0.010, 0.020, 0.030, 0.040,
 		0.050, 0.065, 0.080, 0.100,
 		0.150, 0.200, 0.250, 0.300,
 		0.500, 0.750, 1.000, 1.500,
 		2.000, 5.000, 10.000)
 
-	sizeBucketsOpt := metric.WithExplicitBucketBoundaries(
+	sizeBucketsOpt = metric.WithExplicitBucketBoundaries(
 		0, 256, 512, 1024, // <- reasonable response sizes
 		4*1024, 8*1024, 16*1024, 32*1024, // <- these starts to be big
 		64*1024, 4*64*1024, 8*64*1024, 16*64*1024, // <- those are huge for an api response 64k to 1 Meg