Merge pull request #11 from aikikode/master

Enable async decorator parametrization

Author: kammala

fqn_decorators/asynchronous.py

@@ -9,19 +9,25 @@
 
 
 class AsyncDecorator(Decorator):
-    async def __call__(self, *args, **kwargs):
+    # __call__ should be sync to return a decorator class object, not a coroutine
+    def __call__(self, *args, **kwargs):
+        if not self.func:
+            # Decorator initialized without providing the function (parametrised decorator)
+            return self.__class__(args[0], **self.params)
+
         self.fqn = self.get_fqn()
         self.args = args
         self.kwargs = kwargs
 
-        self.before()
-        try:
-            self.result = await self.func(*self.args, **self.kwargs)
-        except:
-            self.exc_info = sys.exc_info()
-            self.exception()
-            raise
-        finally:
-            self.after()
-
-        return self.result
+        async def async_wrapper(*args, **kwargs):
+            self.before()
+            try:
+                self.result = await self.func(*self.args, **self.kwargs)
+            except:
+                self.exc_info = sys.exc_info()
+                self.exception()
+                raise
+            finally:
+                self.after()
+            return self.result
+        return async_wrapper(*args, **kwargs)

tests/test_fqn_decorators_asynchronous.py

@@ -4,6 +4,10 @@
 from fqn_decorators.asynchronous import AsyncDecorator
 
 
+class CustomException(Exception):
+    pass
+
+
 class TestFqnAsync:
     def test_class_async(self):
         assert get_fqn(AsyncDecorator) == \
@@ -109,3 +113,30 @@ def check_permission(self):
 
         with pytest.raises(RuntimeError):
             await User().check_permission()
+
+    async def test_function_parametrized_decoration_expected(self):
+        class Decorator(AsyncDecorator):
+            def after(self):
+                if 'decorator_param' not in self.params:
+                    raise CustomException('No decorator param')
+                self.result = self.params['decorator_param']
+
+        @Decorator
+        async def return_decorator_value():
+            return False
+
+        with pytest.raises(CustomException):
+            await return_decorator_value()
+
+    async def test_function_parametrized_decoration(self):
+        class Decorator(AsyncDecorator):
+            def after(self):
+                if 'decorator_param' not in self.params:
+                    raise CustomException('No decorator param')
+                self.result = self.params['decorator_param']
+
+        @Decorator(decorator_param='hello')
+        async def return_decorator_value():
+            return False
+
+        assert await return_decorator_value() == 'hello'