Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Make sure display modes are explicitly set everywhere #23

Open
1 task
coenkoopmans opened this issue Dec 4, 2019 · 1 comment
Open
1 task

Make sure display modes are explicitly set everywhere #23

coenkoopmans opened this issue Dec 4, 2019 · 1 comment
Assignees
Labels
prio:low Priority: Low type:idea Type: Idea (not for now, maybe later) type:task Type: Task (miscellaneous code changes)

Comments

@coenkoopmans
Copy link
Contributor

coenkoopmans commented Dec 4, 2019

Description

Some display modes are inferred by the KPN Style portals' choices of HTML element. For example, the current documentation offers this example for a notification:
<div class="notification notification--informative">

However, users of KPN Style might choose to make this a <span>-element, or even something else entirely. That could change the default display mode (which would be block for the div, but inline for the span), which could in turn lead to unexpected results. That could be detrimental to the delivery of consistent experiences by KPN Style.

Therefore, we should explicitly set display modes for at least all parent classes (such as notification, button, or card).

Acceptance criteria

  • All parent classes have their display mode set explicitly
@coenkoopmans coenkoopmans added type:task Type: Task (miscellaneous code changes) prio:low Priority: Low labels Dec 4, 2019
@jordybulten
Copy link
Contributor

We are not sure yet and should investigate further. If you do the parent tag, you also should do it for all child elements to be useful.
Maybe it can also be fixed with a short documentation piece about symantic HTML

@jordybulten jordybulten added the type:idea Type: Idea (not for now, maybe later) label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prio:low Priority: Low type:idea Type: Idea (not for now, maybe later) type:task Type: Task (miscellaneous code changes)
Projects
None yet
Development

No branches or pull requests

3 participants