You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Some display modes are inferred by the KPN Style portals' choices of HTML element. For example, the current documentation offers this example for a notification: <div class="notification notification--informative">
However, users of KPN Style might choose to make this a <span>-element, or even something else entirely. That could change the default display mode (which would be block for the div, but inline for the span), which could in turn lead to unexpected results. That could be detrimental to the delivery of consistent experiences by KPN Style.
Therefore, we should explicitly set display modes for at least all parent classes (such as notification, button, or card).
Acceptance criteria
All parent classes have their display mode set explicitly
The text was updated successfully, but these errors were encountered:
We are not sure yet and should investigate further. If you do the parent tag, you also should do it for all child elements to be useful.
Maybe it can also be fixed with a short documentation piece about symantic HTML
Description
Some display modes are inferred by the KPN Style portals' choices of HTML element. For example, the current documentation offers this example for a notification:
<div class="notification notification--informative">
However, users of KPN Style might choose to make this a
<span>
-element, or even something else entirely. That could change the default display mode (which would beblock
for thediv
, butinline
for thespan
), which could in turn lead to unexpected results. That could be detrimental to the delivery of consistent experiences by KPN Style.Therefore, we should explicitly set display modes for at least all parent classes (such as
notification
,button
, orcard
).Acceptance criteria
The text was updated successfully, but these errors were encountered: