Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context argument doesn't work in some methods #145

Closed
liusiomn opened this issue Oct 14, 2016 · 2 comments
Closed

context argument doesn't work in some methods #145

liusiomn opened this issue Oct 14, 2016 · 2 comments

Comments

@liusiomn
Copy link

` function diffChars(oldStr:string, newStr:string):IDiffResult[];

function diffWords(oldStr:string, newStr:string):IDiffResult[];

function diffWordsWithSpace(oldStr:string, newStr:string):IDiffResult[];

function diffJson(oldObj: Object, newObj: Object): IDiffResult[];

function diffLines(oldStr:string, newStr:string):IDiffResult[];

function diffCss(oldStr:string, newStr:string):IDiffResult[];

function createPatch(fileName: string, oldStr: string, newStr: string, oldHeader: string, newHeader: string, options?: {context: number}): string;`

some methods seem don't have context argument. However, those method should have according to your API readme.

@ExplodingCabbage
Copy link
Collaborator

Looks like this report is about the TypeScript type definitions contained in DefinitelyTyped, which aren't part of jsdiff nor maintained by its maintainers (though perhaps jsdiff should have its own type definitions!). Also looks like this has at least partly fixed by now (perhaps completely - I didn't check).

@ExplodingCabbage ExplodingCabbage closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2023
@ExplodingCabbage
Copy link
Collaborator

Separate issue for making type definitions part of jsdiff: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants