Fix some clippy warnings

Author: kpcyrd

tools/src/schedule/archlinux.rs

@@ -71,12 +71,12 @@ impl TryInto<ArchPkg> for NewPkg {
 
     fn try_into(self: NewPkg) -> Result<ArchPkg> {
         Ok(ArchPkg {
-            name: self.name.get(0).ok_or_else(|| anyhow!("Missing pkg name field"))?.to_string(),
-            base: self.base.get(0).ok_or_else(|| anyhow!("Missing pkg base field"))?.to_string(),
-            filename: self.filename.get(0).ok_or_else(|| anyhow!("Missing filename field"))?.to_string(),
-            version: self.version.get(0).ok_or_else(|| anyhow!("Missing version field"))?.to_string(),
-            architecture: self.architecture.get(0).ok_or_else(|| anyhow!("Missing architecture field"))?.to_string(),
-            packager: self.packager.get(0).ok_or_else(|| anyhow!("Missing packager field"))?.to_string(),
+            name: self.name.first().ok_or_else(|| anyhow!("Missing pkg name field"))?.to_string(),
+            base: self.base.first().ok_or_else(|| anyhow!("Missing pkg base field"))?.to_string(),
+            filename: self.filename.first().ok_or_else(|| anyhow!("Missing filename field"))?.to_string(),
+            version: self.version.first().ok_or_else(|| anyhow!("Missing version field"))?.to_string(),
+            architecture: self.architecture.first().ok_or_else(|| anyhow!("Missing architecture field"))?.to_string(),
+            packager: self.packager.first().ok_or_else(|| anyhow!("Missing packager field"))?.to_string(),
         })
     }
 }

worker/src/download.rs

@@ -12,16 +12,17 @@ pub async fn download(url_str: &str, path: &Path) -> Result<PathBuf> {
     let filename = url.path_segments()
         .ok_or_else(|| format_err!("Url doesn't seem to have a path"))?
         .last()
-        .ok_or_else(|| format_err!("Failed to get filename from path"))?;
+        .ok_or_else(|| format_err!("Failed to get filename from path"))?
+        .to_owned();
     if filename.is_empty() {
-        bail!("Filename is empty");
+        bail!("Filename detected from url is empty");
     }
 
-    let target = path.join(filename);
+    let target = path.join(&filename);
 
     info!("Downloading {:?} to {:?}", url_str, target);
     let client = reqwest::Client::new();
-    let mut stream = client.get(&url.to_string())
+    let mut stream = client.get(url)
         .send()
         .await?
         .error_for_status()?

worker/src/main.rs

@@ -34,7 +34,7 @@ pub struct HttpHeartBeat<'a> {
 }
 
 #[async_trait]
-impl<'a> heartbeat::HeartBeat for HttpHeartBeat<'a> {
+impl heartbeat::HeartBeat for HttpHeartBeat<'_> {
     fn interval(&self) -> Duration {
         Duration::from_secs(PING_INTERVAL)
     }

worker/src/rebuild.rs

@@ -128,7 +128,7 @@ pub async fn rebuild(ctx: &Context<'_>, log: &mut Vec<u8>,) -> Result<Vec<(PkgAr
             .await
             .with_context(|| anyhow!("Failed to download build input from {:?}", input_url))?
     } else {
-        artifacts.get(0)
+        artifacts.first()
             .context("Failed to use first artifact as build input")?
             .1.to_owned()
     };