[core] Add spdlog for rotation filename format (ray-project#49365)

Signed-off-by: dentiny <[email protected]>

Author: dentiny

bazel/ray_deps_setup.bzl

@@ -131,6 +131,11 @@ def ray_deps_setup():
         build_file = "@com_github_ray_project_ray//bazel:BUILD.spdlog",
         urls = ["https://github.com/gabime/spdlog/archive/v1.12.0.zip"],
         sha256 = "6174bf8885287422a6c6a0312eb8a30e8d22bcfcee7c48a6d02d1835d7769232",
+        # spdlog rotation filename format conflict with ray, update the format.
+        patches = [
+            "@com_github_ray_project_ray//thirdparty/patches:spdlog-rotation-file-format.patch",
+        ],
+        patch_args = ["-p1"],
     )
 
     auto_http_archive(

thirdparty/patches/spdlog-rotation-file-format.patch

@@ -0,0 +1,33 @@
+commit 2d6bc609769eaa4a70a6dd384351f54c6633f3a9
+Author: dentiny <[email protected]>
+Date:   Thu Dec 19 17:17:56 2024 +0000
+
+    patch spdlog rotation filename
+
+    Signed-off-by: dentiny <[email protected]>
+
+diff --git a/include/spdlog/sinks/rotating_file_sink-inl.h b/include/spdlog/sinks/rotating_file_sink-inl.h
+index cf8b9d5c..7580c06f 100644
+--- a/include/spdlog/sinks/rotating_file_sink-inl.h
++++ b/include/spdlog/sinks/rotating_file_sink-inl.h
+@@ -50,7 +50,7 @@ SPDLOG_INLINE rotating_file_sink<Mutex>::rotating_file_sink(
+ }
+
+ // calc filename according to index and file extension if exists.
+-// e.g. calc_filename("logs/mylog.txt, 3) => "logs/mylog.3.txt".
++// e.g. calc_filename("logs/mylog.txt, 3) => "logs/mylog.txt.3".
+ template<typename Mutex>
+ SPDLOG_INLINE filename_t rotating_file_sink<Mutex>::calc_filename(const filename_t &filename, std::size_t index)
+ {
+@@ -58,10 +58,7 @@ SPDLOG_INLINE filename_t rotating_file_sink<Mutex>::calc_filename(const filename
+     {
+         return filename;
+     }
+-
+-    filename_t basename, ext;
+-    std::tie(basename, ext) = details::file_helper::split_by_extension(filename);
+-    return fmt_lib::format(SPDLOG_FILENAME_T("{}.{}{}"), basename, index, ext);
++    return fmt_lib::format(SPDLOG_FILENAME_T("{}.{}"), filename, index);
+ }
+
+ template<typename Mutex>